From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, "Denis V. Lunev" <den@openvz.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
Date: Tue, 1 Mar 2016 13:00:21 +0100 [thread overview]
Message-ID: <56D58455.8040605@de.ibm.com> (raw)
In-Reply-To: <20160211154505.GA10359@stefanha-x1.localdomain>
On 02/11/2016 04:45 PM, Stefan Hajnoczi wrote:
> On Tue, Feb 09, 2016 at 07:49:05PM +0300, Denis V. Lunev wrote:
>> we should call trace_init_backends() before trace_init_file() for
>> CONFIG_TRACE_SIMPLE There is no difference for other cases.
>>
>> This problem was introduced by the commit
>> commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
>> Author: Paolo Bonzini <pbonzini@redhat.com>
>> Date: Thu Jan 7 16:55:24 2016 +0300
>>
>> trace: split trace_init_file out of trace_init_backends
>>
>> 'make check' was failed as a result if configured with
>> --enable-trace-backends=simple
>>
>> Spotted by Alex Bennée.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Alex Bennée <alex.bennee@linaro.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> vl.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing
>
> Stefan
When is this scheduled for integration? Without that patch not
only make check is broken, libvirt will also hang if qemu was
build with --enable-trace-backends=simple during capability
detection.
Christian
next prev parent reply other threads:[~2016-03-01 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 16:49 [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization Denis V. Lunev
2016-02-09 22:20 ` Alex Bennée
2016-02-10 9:32 ` Christian Borntraeger
2016-02-11 15:45 ` Stefan Hajnoczi
2016-03-01 12:00 ` Christian Borntraeger [this message]
2016-03-01 13:36 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D58455.8040605@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).