From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37073)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1aaj0G-0002ji-N3
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:02:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1aaj0A-0003gV-7z
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:02:12 -0500
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:37261)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1aaj09-0003ft-UA
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:02:06 -0500
Received: from localhost
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Tue, 1 Mar 2016 12:02:02 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 871921B08067
	for <qemu-devel@nongnu.org>; Tue,  1 Mar 2016 12:02:04 +0000 (GMT)
Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com
	[9.149.37.228])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u21C1gVj43909172
	for <qemu-devel@nongnu.org>; Tue, 1 Mar 2016 12:01:42 GMT
Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u21C1dLq028346
	for <qemu-devel@nongnu.org>; Tue, 1 Mar 2016 05:01:39 -0700
References: <1455036545-14870-1-git-send-email-den@openvz.org>
	<20160211154505.GA10359@stefanha-x1.localdomain>
From: Christian Borntraeger <borntraeger@de.ibm.com>
Message-ID: <56D58455.8040605@de.ibm.com>
Date: Tue, 1 Mar 2016 13:00:21 +0100
MIME-Version: 1.0
In-Reply-To: <20160211154505.GA10359@stefanha-x1.localdomain>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, "Denis V. Lunev" <den@openvz.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>

On 02/11/2016 04:45 PM, Stefan Hajnoczi wrote:
> On Tue, Feb 09, 2016 at 07:49:05PM +0300, Denis V. Lunev wrote:
>> we should call trace_init_backends() before trace_init_file() for
>> CONFIG_TRACE_SIMPLE There is no difference for other cases.
>>
>> This problem was introduced by the commit
>>     commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
>>     Author: Paolo Bonzini <pbonzini@redhat.com>
>>     Date:   Thu Jan 7 16:55:24 2016 +0300
>>
>>     trace: split trace_init_file out of trace_init_backends
>>
>> 'make check' was failed as a result if configured with
>>   --enable-trace-backends=simple
>>
>> Spotted by Alex Bennée.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Alex Bennée <alex.bennee@linaro.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>  vl.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing
> 
> Stefan

When is this scheduled for integration? Without that patch not
only make check is broken, libvirt will also hang if qemu was 
build with --enable-trace-backends=simple during capability
detection.

Christian