From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aaj3U-00008o-8K
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:05:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aaj3Q-0004E4-1a
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:05:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54154)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aaj3P-0004Ds-Sl
	for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:05:27 -0500
References: <1456771254-17511-1-git-send-email-armbru@redhat.com>
	<1456771254-17511-4-git-send-email-armbru@redhat.com>
	<CAJ+F1CKFj6dM_8X2rK2PJR9V88yzmhMqs-s4LnJfBa8q3-RiZw@mail.gmail.com>
	<871t7ul867.fsf@blackfin.pond.sub.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56D58583.6080206@redhat.com>
Date: Tue, 1 Mar 2016 13:05:23 +0100
MIME-Version: 1.0
In-Reply-To: <871t7ul867.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 03/38] event_notifier: Make
 event_notifier_init_fd() #ifdef CONFIG_EVENTFD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@gmail.com>
Cc: cam <cam@cs.ualberta.ca>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU <qemu-devel@nongnu.org>, David Marchand <david.marchand@6wind.com>



On 01/03/2016 13:00, Markus Armbruster wrote:
> Marc-Andr=C3=A9 Lureau <marcandre.lureau@gmail.com> writes:
>=20
>> Hi
>>
>> On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster <armbru@redhat.com>=
 wrote:
>>> Event notifiers are designed for eventfd(2).  They can fall back to
>>> pipes, but according to Paolo, event_notifier_init_fd() really
>>> requires the real thing, and should therefore be under #ifdef
>>> CONFIG_EVENTFD.  Do that.
>>>
>>> Its only user is ivshmem, which is currently CONFIG_POSIX.  Narrow it
>>> to CONFIG_EVENTFD.
>>>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>>>  default-configs/pci.mak     | 2 +-
>>>  util/event_notifier-posix.c | 6 ++++++
>>>  2 files changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/default-configs/pci.mak b/default-configs/pci.mak
>>> index 4fa9a28..9c8bc68 100644
>>> --- a/default-configs/pci.mak
>>> +++ b/default-configs/pci.mak
>>> @@ -36,5 +36,5 @@ CONFIG_SDHCI=3Dy
>>>  CONFIG_EDU=3Dy
>>>  CONFIG_VGA=3Dy
>>>  CONFIG_VGA_PCI=3Dy
>>> -CONFIG_IVSHMEM=3D$(CONFIG_POSIX)
>>> +CONFIG_IVSHMEM=3D$(CONFIG_EVENTFD)
>>
>> This narrows ivshmem to eventfd os only. Eventually after the split,
>> it is easier to bring back posix for ivshmem-plain,
>=20
> Good point.
>=20
>>                                                     but it's important
>> to highlight this change.
>=20
> Yes.  Any ideas on how to highlight it more?

Release notes should do, under "Build dependencies".

Paolo