From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aajFW-0006RV-RU for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:17:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aajFS-0007dW-Th for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:17:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aajFS-0007dR-OG for qemu-devel@nongnu.org; Tue, 01 Mar 2016 07:17:54 -0500 References: <1456771254-17511-1-git-send-email-armbru@redhat.com> <1456771254-17511-31-git-send-email-armbru@redhat.com> <56D5802F.4090700@redhat.com> <87oaayjsyj.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <56D5886D.2070509@redhat.com> Date: Tue, 1 Mar 2016 13:17:49 +0100 MIME-Version: 1.0 In-Reply-To: <87oaayjsyj.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 30/38] ivshmem: Simplify memory regions for BAR 2 (shared memory) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: claudio.fontana@huawei.com, cam@cs.ualberta.ca, mlureau@redhat.com, qemu-devel@nongnu.org, david.marchand@6wind.com On 01/03/2016 13:14, Markus Armbruster wrote: >> > Can you explain why we don't do that anymore to someone who hasn't read >> > patches 4 to 28? :-) Is it patch 23? > Yes, but you also need 24 to complete the job. > > Commit message could perhaps explain it like this: > > ivshmem_realize() puts the shared memory region in a container > region. Used to be necessary to permit delayed mapping of the > shared memory. However, we recently moved to synchronous mapping, > in "ivshmem: Receive shared memory synchronously in realize()" and > the commit following it. The container is redundant since then. > Drop it. > > Better? Yes, thanks! Paolo