From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aamVc-0004fF-DJ for qemu-devel@nongnu.org; Tue, 01 Mar 2016 10:46:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aamVW-0002UD-M8 for qemu-devel@nongnu.org; Tue, 01 Mar 2016 10:46:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aamVW-0002Tz-Ee for qemu-devel@nongnu.org; Tue, 01 Mar 2016 10:46:42 -0500 References: <1456771254-17511-1-git-send-email-armbru@redhat.com> <1456771254-17511-9-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56D5B960.3080402@redhat.com> Date: Tue, 1 Mar 2016 08:46:40 -0700 MIME-Version: 1.0 In-Reply-To: <1456771254-17511-9-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4wJxaIElr4ChLCSSh463uXx7MT9EepEEO" Subject: Re: [Qemu-devel] [PATCH 08/38] ivshmem: Rewrite specification document List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mlureau@redhat.com, cam@cs.ualberta.ca, claudio.fontana@huawei.com, david.marchand@6wind.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4wJxaIElr4ChLCSSh463uXx7MT9EepEEO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/29/2016 11:40 AM, Markus Armbruster wrote: > This started as an attempt to update ivshmem_device_spec.txt for > clarity, accuracy and completeness while working on its code, and > quickly became a full rewrite. Since the diff would be useless > anyway, I'm using the opportunity to rename the file to > ivshmem-spec.txt. >=20 > I tried hard to ensure the new text contradicts neither the old text > nor the code. If the new text contradicts the old text but not the > code, it's probably a bug in the old text. If the new text > contradicts both, its probably a bug in the new text. >=20 > Signed-off-by: Markus Armbruster > --- > +If the server terminates without sending disconnect notifications for > +its connected clients, the clients can elect to continue. They can > +communicate with each other normally, but won't receive disconnect > +notification on disconnect, and no new clients can connect. There is > +no way for the clients to connect to a restarted the server. The s/the server/server/ > +device is not capable to tell guest software whether the server is > +still up. Wow - lots of shortcomings in the server protocol. Food for thought for future improvements, but I'm happy with your approach of just documenting pitfalls for now. > + > +Known bugs: > + > +* The protocol changed incompatibly in QEMU 2.5. Before, messages > + were native endian long, and there was no version number. > + > +* The protocol is poorly designed. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4wJxaIElr4ChLCSSh463uXx7MT9EepEEO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW1blgAAoJEKeha0olJ0NqDCkH/3RF2/d4xxrAVp2aQV5S3V27 +68jTZ8j5yYWwe/hlfFuFRXxa3/YLu4vO33eK7s/kcG2qfUfkf6jB7WkCl+8fnsT QLD51kWoBJ4OCY3r7taC0pOHo9nVEJAjKQ6AHtfeIhwEwCu2ac7Plx3S4BNuMjHw 2iqtotUUi3vTt91TkKXQy9Nz36pOZRVgMrTs+V2MZh8BlxapHn7xJ1WxRB0InVRz iPsrm5FyGFfnUppt/EjQbLgkLKczurSBvgHHuXDWpBSoe4pMSlsqwUQUqIcb5YyT hCPc3orFW+q/OVEonDV3UtuB+T+H0DBDyq2RDNtF5GC3tpnnu7JUzULfIkFZYjo= =tRhL -----END PGP SIGNATURE----- --4wJxaIElr4ChLCSSh463uXx7MT9EepEEO--