From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aamfv-0005qt-O6 for qemu-devel@nongnu.org; Tue, 01 Mar 2016 10:57:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aamfr-000682-NP for qemu-devel@nongnu.org; Tue, 01 Mar 2016 10:57:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aamfr-00067w-GF for qemu-devel@nongnu.org; Tue, 01 Mar 2016 10:57:23 -0500 References: <1456450742-13905-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1456450742-13905-3-git-send-email-xiecl.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <56D5BBE1.50301@redhat.com> Date: Tue, 1 Mar 2016 08:57:21 -0700 MIME-Version: 1.0 In-Reply-To: <1456450742-13905-3-git-send-email-xiecl.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7t63Ks5UKipOucS6QgK7NrJWGjHQ99DIO" Subject: Re: [Qemu-devel] [PATCH v7 2/3] qmp event: Refactor QUORUM_REPORT_BAD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Changlong Xie , qemu devel , Alberto Garcia , Kevin Wolf , Max Reitz , Markus Armbruster Cc: "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7t63Ks5UKipOucS6QgK7NrJWGjHQ99DIO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/25/2016 06:39 PM, Changlong Xie wrote: > Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible > with it. >=20 > Cc: Dr. David Alan Gilbert > Cc: Wen Congyang > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > --- > +Read operation: > { "event": "QUORUM_REPORT_BAD", > - "data": { "node-name": "node0", "sector-num": 345435, "sectors-co= unt": 5 }, > + "data": { "node-name": "node0", "sector-num": 345435, "sectors-co= unt": 5, > + "type": "read" }, > "timestamp": { "seconds": 1344522075, "microseconds": 745528 } } > =20 > +Flush operation: > +{ "event": "QUORUM_REPORT_BAD", > + "data": { "node-name": "node0", "sector-num": 0, "sectors-count":= 2097120, > + "type": "flush", "error": "Broken pipe" }, > + "timestamp": { "seconds": 1456406829, "microseconds": 291763 } } > + > Note: this event is rate-limited. Question - do we care if rate limiting masks one type of failure due to another? Or put another way, are we okay with a single rate-limiting queue for all three types, or do we want three queues? Also, shouldn't this have a queue per child node (I don't want to be flooded with multiple notifications in one second that child1 has failed, but I _do_ want notifications if both child1 and child2 fail in the same second). But that's for future patches to change; it does not need to hold up the current series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7t63Ks5UKipOucS6QgK7NrJWGjHQ99DIO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW1bvhAAoJEKeha0olJ0NqN2sIAIpe5gsycSK/eREiKp91SGq1 YhgRmA9JLQUc7n2ZUW3M1djgYcSuO06i4up5dcZspdC4Q5Xesg2dhVYdDvOPFYqc 2HVwWxrCc0xYnewRhr8UUqiKQxs8Kq42yA0TAvOjERHTm6oVg8lxHqm039m6KuxO /EFTtRqYUXP4Z1xQAVPyAV9LhQCN/gWAtr3X1BNYa6eRinrkL6t9xTWQeVWFtTer nWSSdN9Adv8nBPur7att0evM3TIEYMLuk3nrtr2WgppoNXa4tYYQ6vMqZEb/9dwx w9kG55fvZ595ZxmIv47sHItQmfJefFWmgdqW3UrOWvCVA3+QBaMW/ZhcL8h+230= =XxR9 -----END PGP SIGNATURE----- --7t63Ks5UKipOucS6QgK7NrJWGjHQ99DIO--