From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aamnt-0003Gr-Cb for qemu-devel@nongnu.org; Tue, 01 Mar 2016 11:05:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aamnp-0008MF-Sp for qemu-devel@nongnu.org; Tue, 01 Mar 2016 11:05:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aamnp-0008M8-JK for qemu-devel@nongnu.org; Tue, 01 Mar 2016 11:05:37 -0500 References: <1456847650-4476-1-git-send-email-martin.galvan@tallertechnologies.com> <1456847859-4771-1-git-send-email-martin.galvan@tallertechnologies.com> From: Eric Blake Message-ID: <56D5BDCF.1050804@redhat.com> Date: Tue, 1 Mar 2016 09:05:35 -0700 MIME-Version: 1.0 In-Reply-To: <1456847859-4771-1-git-send-email-martin.galvan@tallertechnologies.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="91JxRLF5pD2Rgu8CCf1a3WNnRvRwdhp0F" Subject: Re: [Qemu-devel] [PATCH v2 01/13] Use unsigned types for the 'len' argument of all memory read/write functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Martin Galvan , qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, edgar.iglesias@gmail.com, rth@twiddle.net, aurelien@aurel32.net, kraxel@redhat.com, blauwirbel@gmail.com, lcapitulino@redhat.com, armbru@redhat.com, afaerber@suse.de, dmitry@daynix.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --91JxRLF5pD2Rgu8CCf1a3WNnRvRwdhp0F Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/01/2016 08:57 AM, Martin Galvan wrote: Missing a S-o-b line; we cannot accept patches unless you sign them: http://wiki.qemu.org/Contribute/SubmitAPatch https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Docu= mentation/SubmittingPatches?id=3Df6f94e2a#n297 Subject line is long, and lacking a 'topic: summary' prefix. I'd suggest= : mem: use unsigned 'len' for read/write Then give more details, if needed, in the body of the commit message. Also, your threading didn't work right. Patch 1/13 was sent with: References: <1456847859-4771-1-git-send-email-martin.galvan@tallertechnologies.com> but with no In-Reply-To:. Meanwhile, the 00/13 cover letter was sent with= : Message-Id: <1456847681-4532-1-git-send-email-martin.galvan@tallertechnologies.com> which is subtly different from the references of all the other patches, making it appear as separate threads. > --- > cpus.c | 2 +- > exec.c | 29 +++++++++++++++-------------- > include/exec/cpu-all.h | 2 +- > include/exec/cpu-common.h | 10 +++++----- > include/exec/memory.h | 10 +++++----- > kvm-all.c | 2 +- > 6 files changed, 28 insertions(+), 27 deletions(-) >=20 > diff --git a/cpus.c b/cpus.c > index 9592163..e7aa8cc 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -1602,7 +1602,7 @@ void qmp_memsave(int64_t addr, int64_t size, cons= t char *filename, > bool has_cpu, int64_t cpu_index, Error **errp) > { > FILE *f; > - uint32_t l; > + size_t l; These are both unsigned types. So based on the subject line alone, this doesn't fit in the patch, unless the commit message body goes into more details on why you are changing the size of the type, and not just the signedness. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --91JxRLF5pD2Rgu8CCf1a3WNnRvRwdhp0F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW1b3PAAoJEKeha0olJ0NqNiIH/3QGHBGLbUzr/L7HRX0AQZZs zUC7wKBwLr466WXztUJEEDaWIOLEQhsJyEfh67Kdh3APah2PSslKF+U//Y1pPoeN KRkGTTtsmYEfBcyjsCQrCFgSaai4aLS91vh1oS4ZGr8U4gIM2x5UPgfXianRGcNC Tyal/NVBCsDEq9Sz5qI9tCW3lrWTCIsSzchrwvYS5iywT8xdBrnsuvZh5N9zyr0H gX16O3CnXrtyyay6JDBEn+eetMvb4/QUJBMwttIsW86in22U/TxvBTSyZbDWsJSK 48jZZ0cEfEHJ89VGom+96Sb+7c24KJF6nYxfaJhs4Zf9MUdtCQQXGZCf0X6hhjA= =cM0+ -----END PGP SIGNATURE----- --91JxRLF5pD2Rgu8CCf1a3WNnRvRwdhp0F--