From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jmp helper
Date: Tue, 1 Mar 2016 08:28:07 -0800 [thread overview]
Message-ID: <56D5C317.7030709@twiddle.net> (raw)
In-Reply-To: <1456845145-18891-1-git-send-email-pbonzini@redhat.com>
On 03/01/2016 07:12 AM, Paolo Bonzini wrote:
> One flag was tested the wrong way.
>
> Cc: rth@twiddle.net
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target-i386/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index b345e2c..ebd8995 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -2420,7 +2420,7 @@ static void gen_bnd_jmp(DisasContext *s)
> itself will check BNDPRESERVE at runtime. */
> if ((s->prefix & PREFIX_REPNZ) == 0
> && (s->flags & HF_MPX_EN_MASK) == 0
> - && (s->flags & HF_MPX_IU_MASK) == 0) {
> + && (s->flags & HF_MPX_IU_MASK) != 0) {
Ho hum. Two flags tested the wrong way -- EN_MASK should be on as well.
r~
prev parent reply other threads:[~2016-03-01 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 15:12 [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jmp helper Paolo Bonzini
2016-03-01 16:28 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D5C317.7030709@twiddle.net \
--to=rth@twiddle.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).