From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aan9k-0002av-Gv for qemu-devel@nongnu.org; Tue, 01 Mar 2016 11:28:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aan9f-0006n7-E3 for qemu-devel@nongnu.org; Tue, 01 Mar 2016 11:28:16 -0500 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]:33996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aan9f-0006ms-9r for qemu-devel@nongnu.org; Tue, 01 Mar 2016 11:28:11 -0500 Received: by mail-qk0-x230.google.com with SMTP id x1so71151824qkc.1 for ; Tue, 01 Mar 2016 08:28:10 -0800 (PST) Sender: Richard Henderson References: <1456845145-18891-1-git-send-email-pbonzini@redhat.com> From: Richard Henderson Message-ID: <56D5C317.7030709@twiddle.net> Date: Tue, 1 Mar 2016 08:28:07 -0800 MIME-Version: 1.0 In-Reply-To: <1456845145-18891-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jmp helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 03/01/2016 07:12 AM, Paolo Bonzini wrote: > One flag was tested the wrong way. > > Cc: rth@twiddle.net > Signed-off-by: Paolo Bonzini > --- > target-i386/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-i386/translate.c b/target-i386/translate.c > index b345e2c..ebd8995 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -2420,7 +2420,7 @@ static void gen_bnd_jmp(DisasContext *s) > itself will check BNDPRESERVE at runtime. */ > if ((s->prefix & PREFIX_REPNZ) == 0 > && (s->flags & HF_MPX_EN_MASK) == 0 > - && (s->flags & HF_MPX_IU_MASK) == 0) { > + && (s->flags & HF_MPX_IU_MASK) != 0) { Ho hum. Two flags tested the wrong way -- EN_MASK should be on as well. r~