From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aanfS-0002E0-D7 for qemu-devel@nongnu.org; Tue, 01 Mar 2016 12:01:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aanfR-00029U-Bc for qemu-devel@nongnu.org; Tue, 01 Mar 2016 12:01:02 -0500 References: <1455111073-5600-1-git-send-email-marcel@redhat.com> From: Marcel Apfelbaum Message-ID: <56D5CABB.6050104@gmail.com> Date: Tue, 1 Mar 2016 19:00:43 +0200 MIME-Version: 1.0 In-Reply-To: <1455111073-5600-1-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 0/2] hw/virtio: fix double use of a virtio flag Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: lvivier@redhat.com, jasowang@redhat.com, qemu-stable@nongnu.org, mst@redhat.com On 02/10/2016 03:31 PM, Marcel Apfelbaum wrote: > To the obvious question of "how did that happen?" > I can say we had an unlucky break. > Both Jason and me worked on a new different virtio feature in the same > time, and they were both merged in the same pull request. > We both saw BIT 3 as the last used > https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03041.html > > Commits 1811e64c and a6df8adf use the same virtio feature bit 4 > for different features. > > Fix it by using different bits. > While at it, group all the virtio flags into an enum to avoid that > in the feature. > ping Thanks, Marcel > > v1 -> v2: > - Addressed Laurent Vivier's comment: > - forgot to remove a flag > - Added teset-by to the first patch > > Marcel Apfelbaum (2): > hw/virtio: fix double use of a virtio flag > hw/virtio: group virtio flags into an enum > > hw/virtio/virtio-pci.h | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) >