From: Paolo Bonzini <pbonzini@redhat.com>
To: Huaicheng Li <lhcwhu@gmail.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup
Date: Tue, 1 Mar 2016 22:01:50 +0100 [thread overview]
Message-ID: <56D6033E.2070402@redhat.com> (raw)
In-Reply-To: <FD610E23-37F8-4C0C-987A-8CF254C82667@gmail.com>
On 01/03/2016 19:45, Huaicheng Li wrote:
>
> * Is it safe to call `qemu_paio_submit` from one worker thread? Since
> all request_access accesses are protected by lock, I think this is
> OK.
No, it's not possible. The "all" list in thread-pool.c is protected
with the AioContext lock, not with the thread pool lock. This is done
because the worker threads only care about the queued request list, not
about active or completed requests.
Paolo
next prev parent reply other threads:[~2016-03-01 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 18:45 [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup Huaicheng Li
2016-03-01 21:01 ` Paolo Bonzini [this message]
2016-03-06 2:42 ` Huaicheng Li (coperd)
2016-03-07 13:02 ` Paolo Bonzini
2016-03-07 14:32 ` Huaicheng Li (coperd)
2016-03-01 21:34 ` Stefan Hajnoczi
2016-03-06 2:33 ` Huaicheng Li (coperd)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6033E.2070402@redhat.com \
--to=pbonzini@redhat.com \
--cc=lhcwhu@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).