From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aarQe-0004Hc-OB for qemu-devel@nongnu.org; Tue, 01 Mar 2016 16:02:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aarQY-0007mW-TJ for qemu-devel@nongnu.org; Tue, 01 Mar 2016 16:02:00 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:37136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aarQY-0007mM-Ly for qemu-devel@nongnu.org; Tue, 01 Mar 2016 16:01:54 -0500 Received: by mail-wm0-x231.google.com with SMTP id p65so51226302wmp.0 for ; Tue, 01 Mar 2016 13:01:54 -0800 (PST) Sender: Paolo Bonzini References: From: Paolo Bonzini Message-ID: <56D6033E.2070402@redhat.com> Date: Tue, 1 Mar 2016 22:01:50 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Huaicheng Li , qemu-devel@nongnu.org Cc: stefanha@redhat.com On 01/03/2016 19:45, Huaicheng Li wrote: > > * Is it safe to call `qemu_paio_submit` from one worker thread? Since > all request_access accesses are protected by lock, I think this is > OK. No, it's not possible. The "all" list in thread-pool.c is protected with the AioContext lock, not with the thread pool lock. This is done because the worker threads only care about the queued request list, not about active or completed requests. Paolo