From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aatWd-0000SC-0f for qemu-devel@nongnu.org; Tue, 01 Mar 2016 18:16:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aatWY-00019s-1a for qemu-devel@nongnu.org; Tue, 01 Mar 2016 18:16:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aatWX-00019J-Re for qemu-devel@nongnu.org; Tue, 01 Mar 2016 18:16:13 -0500 References: <6FDF78F9-D147-4239-9B8E-CAB1417369AA@gmail.com> From: Eric Blake Message-ID: <56D622BC.6090600@redhat.com> Date: Tue, 1 Mar 2016 16:16:12 -0700 MIME-Version: 1.0 In-Reply-To: <6FDF78F9-D147-4239-9B8E-CAB1417369AA@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="phjCK0CXCbopMmN59jBjhIfgmCinnaWJk" Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid , Peter Maydell , qemu-devel qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --phjCK0CXCbopMmN59jBjhIfgmCinnaWJk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/01/2016 03:12 PM, Programmingkid wrote: > The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCo= de > layout. >=20 > Signed-off-by: John Arbuckle >=20 > --- > Maintainer note: > Please apply these patches before testing:=20 > - qapi-schema.json: Add kp_equals and power keys > - adb.c: Replace pc_to_adb_keycode with more detailed array > - MacKeys.h: initial commit Since this depends on those patches, it might have been nicer to submit it as a series with a 0/4 cover letter, rather than making us chase separate threads. > + > + [MAC_KEY_ESC] =3D Q_KEY_CODE_ESC, > + //[MAC_KEY_F1] =3D Q_KEY_CODE_POWER, // Just in case you need the = power key > + [MAC_KEY_F1] =3D Q_KEY_CODE_F1, The comment looks weird. Probably worth a mention in the commit message why you need it. > =20 > static int cocoa_keycode_to_qemu(int keycode) > { > - if (ARRAY_SIZE(keymap) <=3D keycode) { > + if (ARRAY_SIZE(macToQKeyCodeMap) <=3D keycode) { > fprintf(stderr, "(cocoa) warning unknown keycode 0x%x\n", keyc= ode); Pre-existing, but we should fix this to avoid fprintf. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --phjCK0CXCbopMmN59jBjhIfgmCinnaWJk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW1iK8AAoJEKeha0olJ0Nq63cH/38sXk4dA/ajucxjbQ+qF0NN AjfAW/+Sw01x88I2UbhqAlSXZiFj0aGRt4YiwzwtLadg5twy6lG0WoPntXRO0qqI /972Cir35eE8W+LM2ZJi49PTFKCMQ9hQZKSplGabIsItykY/z35KnFQe/SCFxvSV 6Uu8Vbe4VbrSgKuFuV1HTopp9UZoJwk+/LIPcKak5ejf9SDaOLTzRIDe5wVUHYa7 3Bpg/h+zRGbnFx5gXlgumc654LE1GHUQODaBeG9+K/RpoKiHRnFhT1yZNun2quyD TM2nQ1XfgqBBLO2ATaI0YE6D6WCmiFnN+PmH2PlPfyHAmXMw1ttIinuqnh0ALTs= =DzhV -----END PGP SIGNATURE----- --phjCK0CXCbopMmN59jBjhIfgmCinnaWJk--