From: Eric Blake <eblake@redhat.com>
To: Programmingkid <programmingkidx@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys
Date: Tue, 1 Mar 2016 16:17:10 -0700 [thread overview]
Message-ID: <56D622F6.4090708@redhat.com> (raw)
In-Reply-To: <015BA737-A91F-41D9-BFC5-6F31D5C9D18E@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On 03/01/2016 03:33 PM, Programmingkid wrote:
>
> On Mar 1, 2016, at 5:23 PM, Gerd Hoffmann wrote:
>
>> On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote:
>>> Add kp_equals and power keys support to the QKeyCode enum of keys.
>>
>> Please update the documentation in the comment too, so we keep track of
>> which keys where added in which release.
>>
>> Otherwise it's fine.
>>
>> thanks,
>> Gerd
>>
>
> Is this what you mean:
>
> ##
> # @QKeyCode:
> #
> # An enumeration of key name.
> #
> # This is used by the send-key command.
> #
> # Since: 1.3.0
> #
> # 'unmapped' and 'pause' since 2.0
> # 'ro' and 'kp_comma' since 2.4
> # 'kp_equals' and 'power' since 2.6
Yes.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-01 23:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 22:04 [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys Programmingkid
2016-03-01 22:23 ` Gerd Hoffmann
2016-03-01 22:33 ` Programmingkid
2016-03-01 23:17 ` Eric Blake [this message]
2016-03-02 6:29 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D622F6.4090708@redhat.com \
--to=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).