From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aatZo-0003NR-Jw for qemu-devel@nongnu.org; Tue, 01 Mar 2016 18:19:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aatZl-00024H-CG for qemu-devel@nongnu.org; Tue, 01 Mar 2016 18:19:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aatZl-00024C-6H for qemu-devel@nongnu.org; Tue, 01 Mar 2016 18:19:33 -0500 References: From: Eric Blake Message-ID: <56D62384.5060903@redhat.com> Date: Tue, 1 Mar 2016 16:19:32 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Uq8ncv0Cp7GK30LvRgWwF8vjNEjpalBCk" Subject: Re: [Qemu-devel] [PATCH] MacKeys.h: initial commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Programmingkid Cc: qemu-devel qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Uq8ncv0Cp7GK30LvRgWwF8vjNEjpalBCk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/01/2016 04:08 PM, Peter Maydell wrote: > On 1 March 2016 at 22:07, Programmingkid wr= ote: >> This patch adds the file MacKeys.h. It is a file that contains all the= constants >> for the Macintosh keyboard keycodes. >> >> Signed-off-by: John Arbuckle >> >> --- >> Note to Peter Maydell: >> I know you wanted me to use the constants from the file HIToolbox/Even= ts.h, but >> I can't. It only exists on Mac OS X, so other operating systems like L= inux >> would not be able to use it. This file is also used in the adb.c file,= so >> cross-platform compatibility is a must. >=20 > What I suggested was that you should use the Events.h constants in > ui/cocoa.m (which is OSX only) and have a file in include/hw/input/ > for the keys for the ADB keyboard emulation. >=20 > This patch should really be in a patch series with the patches that > use the new header. >=20 >> include/hw/input/MacKeys.h | 139 +++++++++++++++++++++++++++++++++++= +++++++++ >> 1 files changed, 139 insertions(+), 0 deletions(-) >> create mode 100644 include/hw/input/MacKeys.h Can we please use lower-case naming of mac-keys.h? Just because Mac headers use Capital Names doesn't mean we have to break our internal conventions to follow. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Uq8ncv0Cp7GK30LvRgWwF8vjNEjpalBCk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW1iOEAAoJEKeha0olJ0NqtNIH/R+RwCTAtS2fNqrKg6N1solm 4vEfTEpUYAdxqaRsUp02KE3ih9D1GvwgnRNnLUphcz7cumcLnCHnyER3HVzUnMMO k4xgq9lmYY6Fq6D9sr1gRoSFaurrDsQWOUDNSKVLEQ0q+Gsu1Ft6vl3ToSbIVhjV SSOBIVu0Q+vTDzCo0kvqLffT2dnVWBnJfyuHPrC+ub6tT3NJZME6sSjhxodMGe7b hrpe+R0A6kQal9RgIIiBzJjaiopy8lj1YJrAkUN0chpO4V5+bgJUUijk9bq3vVYK ZLIlljh5NOfN6CyER/cTl/WAacRsRF8rsljUDL7FNzjXosa7aW6cZupdil4uVLc= =oZjQ -----END PGP SIGNATURE----- --Uq8ncv0Cp7GK30LvRgWwF8vjNEjpalBCk--