From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ab0ZR-0003Dr-8P
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 01:47:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ab0ZO-0000u7-3F
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 01:47:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49893)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ab0ZN-0000u2-UJ
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 01:47:38 -0500
References: <1456748635-1912-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<1456748635-1912-4-git-send-email-zhangchen.fnst@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56D68C6D.30800@redhat.com>
Date: Wed, 2 Mar 2016 14:47:09 +0800
MIME-Version: 1.0
In-Reply-To: <1456748635-1912-4-git-send-email-zhangchen.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 3/3] tests/test-filter-redirector: Add
 unit test for filter-redirector
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>, Gui jianfeng <guijianfeng@cn.fujitsu.com>, "eddie.dong" <eddie.dong@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Yang Hongyang <hongyang.yang@easystack.cn>



On 02/29/2016 08:23 PM, Zhang Chen wrote:
> In this unit test,we will test the filter redirector function.
>
> Start qemu with:
>
>         "-netdev tap,id=qtest-bn0 "

Please don't use tap since it needs

- CAP_NET_ADMIN
- if-up script

Neither of above could not be true for a qtest environment.

>         "-device rtl8139,netdev=qtest-bn0,id=qtest-e0 "
>         "-chardev socket,id=redirector0,path=%s,server,nowait "
>         "-chardev socket,id=redirector1,path=%s,server,nowait "
>         "-object filter-redirector,id=qtest-f1,netdev=qtest-bn0,"
>         "queue=tx,indev=redirector1 "
>         "-object filter-redirector,id=qtest-f0,netdev=qtest-bn0,"
>         "queue=tx,outdev=redirector0 "
>
> We inject packet to -chardev redirector1,then filter-redirector
> will pass it to filter, another filter-redirector get it and
> redirect it to redirector0,we read packet from redirector0
> and compare to what we inject.

Looks correct but I think queue='rx' should also be tested here. How about:

- using backend
- redirect tx traffic to a chardev, then inject packet from socket and
read it from chardev
- redirect from another chardev to rx traffic, then inject packet from
chardev and read if from socket?