From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33901)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ab163-000388-Dr
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:21:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ab15z-0001Pi-7T
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:21:23 -0500
Received: from mga01.intel.com ([192.55.52.88]:42823)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ab15z-0001Oj-1j
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 02:21:19 -0500
References: <1456829771-71553-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1456829771-71553-9-git-send-email-guangrong.xiao@linux.intel.com>
	<20160301190240-mutt-send-email-mst@redhat.com>
	<56D65E42.1050108@linux.intel.com>
	<20160302081841-mutt-send-email-mst@redhat.com>
	<56D69307.6040902@linux.intel.com>
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Message-ID: <56D69460.30402@linux.intel.com>
Date: Wed, 2 Mar 2016 15:21:04 +0800
MIME-Version: 1.0
In-Reply-To: <56D69307.6040902@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net



On 03/02/2016 03:15 PM, Xiao Guangrong wrote:

>>>>> +    in = g_malloc(TARGET_PAGE_SIZE);
>>
>> ugh. manual memory management :(
>>
>
> Hmm... Or use GArray? But it is :)

Sorry, typo.

But it is the static size and we should read all memory out to get
the consistent data to avid guest changes it at anytime. It is no
much room to improve it i think...