From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Programmingkid <programmingkidx@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit
Date: Wed, 2 Mar 2016 09:01:57 -0700 [thread overview]
Message-ID: <56D70E75.5080000@redhat.com> (raw)
In-Reply-To: <874mcoj2n9.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On 03/02/2016 08:55 AM, Markus Armbruster wrote:
>>>
>>> Please stick to lower case in file names.
>>
>> Which one do you prefer: mackeys.h or macKeys.h ?
>
> I'd call it mac-keys.h. mackeys.h would be okay. There's enough
> precedence for '_' in file names to justify mac_keys.h, but I personally
> dislike that.
I also suggested "mac-keys.h" in my v1 review:
https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg00364.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-02 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 1:58 [Qemu-devel] [PATCH v2] MacKeys.h: initial commit Programmingkid
2016-03-02 9:32 ` Markus Armbruster
2016-03-02 14:49 ` Programmingkid
2016-03-02 15:55 ` Markus Armbruster
2016-03-02 16:01 ` Eric Blake [this message]
2016-03-02 16:45 ` Peter Maydell
2016-03-02 17:04 ` Programmingkid
2016-03-02 17:13 ` Programmingkid
2016-03-02 17:33 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D70E75.5080000@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).