From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1ab9vp-0006zf-R1
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 11:47:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1ab9vo-0005T4-VE
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 11:47:25 -0500
References: <1456518142-9849-1-git-send-email-kwolf@redhat.com>
	<1456518142-9849-3-git-send-email-kwolf@redhat.com>
From: Max Reitz <mreitz@redhat.com>
Message-ID: <56D71915.1020802@redhat.com>
Date: Wed, 2 Mar 2016 17:47:17 +0100
MIME-Version: 1.0
In-Reply-To: <1456518142-9849-3-git-send-email-kwolf@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="xei2N2LifNv6EPSDCvePlRfLa0OHjut4F"
Subject: Re: [Qemu-devel] [PATCH 2/3] block/qapi: Factor out
	bdrv_query_bds_stats()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--xei2N2LifNv6EPSDCvePlRfLa0OHjut4F
Content-Type: multipart/mixed; boundary="86CjrIPe09740RbTip1pP8h4aqlu7x4CG"
From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Message-ID: <56D71915.1020802@redhat.com>
Subject: Re: [PATCH 2/3] block/qapi: Factor out bdrv_query_bds_stats()
References: <1456518142-9849-1-git-send-email-kwolf@redhat.com>
 <1456518142-9849-3-git-send-email-kwolf@redhat.com>
In-Reply-To: <1456518142-9849-3-git-send-email-kwolf@redhat.com>

--86CjrIPe09740RbTip1pP8h4aqlu7x4CG
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 26.02.2016 21:22, Kevin Wolf wrote:
> The new functions handles the data that is taken from the
> BlockDriverState.
>=20
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/qapi.c | 31 ++++++++++++++++++++-----------
>  1 file changed, 20 insertions(+), 11 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

Now that I see s->stats->wr_highest_offset in this function, thus
piquing my interest in s->stats... How about another patch which makes
bdrv_query_blk_stats() take the BlockDeviceStats pointer instead of
BlockStats?

Max


--86CjrIPe09740RbTip1pP8h4aqlu7x4CG--

--xei2N2LifNv6EPSDCvePlRfLa0OHjut4F
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJW1xkVAAoJEDuxQgLoOKytd6MIAKYhXY/Y/rCW3bBwcaANSOPs
6reSVQ5VbnY2/Z5NmW7cExjrjJmGazJDmULZzFeoVhd9Rd+F6oIZeR9/CYRSqbhQ
daOG9sKq0yBa8hFNSWY5r82TNIbBRCyQRqiNQc6X6Bl8kk/Q/Y+2aUYo6pHuDwEZ
GAXlMdtdRvfJgrTVnw6ONfY9ewq01poFyDk5haKvsdZgqi9z1ESqK1wwp4n7DtmN
Low/9PjWHRf8yj6ACAzs7iM+NalpT+hYMnFwphQQSGfUIKL+FFOyH41YmRjJ881S
oSxIxDi5N02oIV8zmhG77t3zuSEw6/Cmo9gaxYgGOMdPjOLL21oQjl/NEZbWeSE=
=1ChB
-----END PGP SIGNATURE-----

--xei2N2LifNv6EPSDCvePlRfLa0OHjut4F--