From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abA44-0003N3-8S for qemu-devel@nongnu.org; Wed, 02 Mar 2016 11:55:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abA43-0000Pt-6w for qemu-devel@nongnu.org; Wed, 02 Mar 2016 11:55:56 -0500 References: <1456518142-9849-1-git-send-email-kwolf@redhat.com> <1456518142-9849-3-git-send-email-kwolf@redhat.com> <56D71915.1020802@redhat.com> <20160302165252.GG4494@noname.redhat.com> From: Max Reitz Message-ID: <56D71B14.3080605@redhat.com> Date: Wed, 2 Mar 2016 17:55:48 +0100 MIME-Version: 1.0 In-Reply-To: <20160302165252.GG4494@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hHWmllqdb4T58tpRbg8ROtEhLu7ClVrer" Subject: Re: [Qemu-devel] [PATCH 2/3] block/qapi: Factor out bdrv_query_bds_stats() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hHWmllqdb4T58tpRbg8ROtEhLu7ClVrer Content-Type: multipart/mixed; boundary="udouLH6f3wl7Awg2t7JXs5CQTjSe34Kx6" From: Max Reitz To: Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org Message-ID: <56D71B14.3080605@redhat.com> Subject: Re: [PATCH 2/3] block/qapi: Factor out bdrv_query_bds_stats() References: <1456518142-9849-1-git-send-email-kwolf@redhat.com> <1456518142-9849-3-git-send-email-kwolf@redhat.com> <56D71915.1020802@redhat.com> <20160302165252.GG4494@noname.redhat.com> In-Reply-To: <20160302165252.GG4494@noname.redhat.com> --udouLH6f3wl7Awg2t7JXs5CQTjSe34Kx6 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 02.03.2016 17:52, Kevin Wolf wrote: > Am 02.03.2016 um 17:47 hat Max Reitz geschrieben: >> On 26.02.2016 21:22, Kevin Wolf wrote: >>> The new functions handles the data that is taken from the >>> BlockDriverState. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> block/qapi.c | 31 ++++++++++++++++++++----------- >>> 1 file changed, 20 insertions(+), 11 deletions(-) >> >> Reviewed-by: Max Reitz >> >> Now that I see s->stats->wr_highest_offset in this function, thus >> piquing my interest in s->stats... How about another patch which makes= >> bdrv_query_blk_stats() take the BlockDeviceStats pointer instead of >> BlockStats? >=20 > Hm, doesn't work any more after patch 3. I just noticed. :-) > Which doesn't necessarily mean= > that it's a bad thought, maybe s->device can be set in the caller > instead. Seems reasonable to me. Max --udouLH6f3wl7Awg2t7JXs5CQTjSe34Kx6-- --hHWmllqdb4T58tpRbg8ROtEhLu7ClVrer Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW1xsUAAoJEDuxQgLoOKyto78H/0/g4cM+gkJ1MIhd4oGWDb69 vAzU2gl4xRwSYz6zC6CeEPNQbKMSZX4yonzy8WW7hslGAeEWm88Oa2c05CO1zui2 2BCRhU8wBiuDmessSk4MsUDo8JBpeM2/GjbRsjSvf85dA0+lKQ2MsUfG0mno1QKy JBC+X8+NGFCKDFT8xD9Awf56mM/QIitDzWsLytFxbV+MqnsJCRmnD2PEAJF6uQxC aWlJGZ1mvBcKX5u16bxbAwUaRmHLuOKIR6+wZg08oVF6KK0wKCH+hkEQ01i+mGzW /GezluUyQxhwWZ0faSLo1t+o3Jd13yT4fsvO48vunXQpPsag9QRmVQMvPwzW4Vo= =YDZm -----END PGP SIGNATURE----- --hHWmllqdb4T58tpRbg8ROtEhLu7ClVrer--