From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51816)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1abBCZ-0006ao-Jl
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 13:08:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1abBCW-0003bT-DR
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 13:08:47 -0500
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:52181)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1abBCW-0003aU-3k
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 13:08:44 -0500
Received: from localhost
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <clg@fr.ibm.com>;
	Wed, 2 Mar 2016 18:08:42 -0000
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 78F042190056
	for <qemu-devel@nongnu.org>; Wed,  2 Mar 2016 18:08:13 +0000 (GMT)
Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com
	[9.149.37.252])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u22I8TG08585626
	for <qemu-devel@nongnu.org>; Wed, 2 Mar 2016 18:08:29 GMT
Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u22I8TiK009796
	for <qemu-devel@nongnu.org>; Wed, 2 Mar 2016 11:08:29 -0700
References: <1456913698-11452-1-git-send-email-clg@fr.ibm.com>
	<1456913698-11452-3-git-send-email-clg@fr.ibm.com>
	<20160302122030-mutt-send-email-mst@redhat.com>
	<56D72884.6050501@fr.ibm.com>
	<20160302200147-mutt-send-email-mst@redhat.com>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@fr.ibm.com>
Message-ID: <56D72C18.5000409@fr.ibm.com>
Date: Wed, 2 Mar 2016 19:08:24 +0100
MIME-Version: 1.0
In-Reply-To: <20160302200147-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA()
 macro with inline helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>, Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org

On 03/02/2016 07:02 PM, Michael S. Tsirkin wrote:
> On Wed, Mar 02, 2016 at 06:53:08PM +0100, Cédric Le Goater wrote:
>>> typedef struct RspBuffer RspBuffer;
>>
>> OK. So that's the rule for structs in qemu. It is not that clear
>> when you look at the code around. I will change. np.
> 
> Did you look at CODING_STYLE? Pls do.

This is clear. Thanks.

C.