From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abD20-0002pX-P3 for qemu-devel@nongnu.org; Wed, 02 Mar 2016 15:06:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abD1w-0000rl-RK for qemu-devel@nongnu.org; Wed, 02 Mar 2016 15:06:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abD1w-0000rh-LZ for qemu-devel@nongnu.org; Wed, 02 Mar 2016 15:05:56 -0500 References: <1456443528-13901-1-git-send-email-eblake@redhat.com> <1456443528-13901-2-git-send-email-eblake@redhat.com> <87si08hkdk.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56D74791.3050104@redhat.com> Date: Wed, 2 Mar 2016 13:05:37 -0700 MIME-Version: 1.0 In-Reply-To: <87si08hkdk.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hXKrlF6w6SFUR55UMtiMC2O1lW7U9j1LX" Subject: Re: [Qemu-devel] [PATCH v2 01/19] qapi: Rename 'fields' to 'members' in internal interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hXKrlF6w6SFUR55UMtiMC2O1lW7U9j1LX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/02/2016 10:15 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> C types and JSON objects don't have fields, but members. We >> shouldn't gratuitously invent terminology. This patch is a >> strict renaming of generator code and static genarated functions, >> plus the naming of the dummy filler member for empty structs, >> before the next patch exposes some of that naming to the rest of >> the code base. >> >> Suggested-by: Markus Armbruster >> Signed-off-by: Eric Blake >> >> --- >> v2: new patch >=20 > Patch looks good. You could split it into Python renames (no change to= > generated code) and C renames. Only if you like the idea. Sure, not too much work. >=20 > If you want to be *really* thorough: there's a "field" left in > tests/qapi-schema/qapi-schema-test.json, and a few in > docs/qapi-code-gen.txt. I'll save docs/ for 3/19, but get the .json file fixed along with the Python renames. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hXKrlF6w6SFUR55UMtiMC2O1lW7U9j1LX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW10eRAAoJEKeha0olJ0NqdBgH/juiaQDAEdF69y8BhiKemtLz MREvdHPyqlGgJkaH88rB/mcGwBYJ2j6P4bUDBV2HuriXmvylfCtiPnZk7yQrh6u4 BQ8+Ddxhtq0HbA5VUvqxJmj2RAysbk30l+PDZtHVQoM/6PtXXB9K1Bc7k/O5bs1q QkmYFl4MDfKyWQq5alliqQxFP6vhOBei4pbcixmPa9HNSaEC897Tn7w4BHjKyYss zMezFKz7eLMPy0eWhrgHh1OjAaZjmMuUCS4AqvPoXwR1FT5daKui0PkLafIM9W5j sNLddyWYNFuCCh+B4tUU3UNHAF4iFI7IrQYpbAN7o9L/C99Bb8M28tPLf8MDrO4= =PCAW -----END PGP SIGNATURE----- --hXKrlF6w6SFUR55UMtiMC2O1lW7U9j1LX--