From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abFoc-00050Y-Bp for qemu-devel@nongnu.org; Wed, 02 Mar 2016 18:04:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abFoX-0005Mh-QX for qemu-devel@nongnu.org; Wed, 02 Mar 2016 18:04:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abFoX-0005MP-Kw for qemu-devel@nongnu.org; Wed, 02 Mar 2016 18:04:17 -0500 References: <1456443528-13901-1-git-send-email-eblake@redhat.com> <1456443528-13901-12-git-send-email-eblake@redhat.com> <87egbsg0qf.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56D7716F.7090700@redhat.com> Date: Wed, 2 Mar 2016 16:04:15 -0700 MIME-Version: 1.0 In-Reply-To: <87egbsg0qf.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Fqd58s6QKPPwXa9CUCnaIABLDJbPPT5um" Subject: Re: [Qemu-devel] [PATCH v2 11/19] qapi: Add type.is_empty() helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Fqd58s6QKPPwXa9CUCnaIABLDJbPPT5um Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/02/2016 12:04 PM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> And use it in qapi-types and qapi-event. Down the road, we may >> want to lift our artificial restriction of no variants at the >> top level of an event, at which point, inlining our check for >> whether members is empty will no longer be sufficient, but >> adding a check for variants adds verbosity; in the meantime, >> add some asserts in places where we don't handle variants. >=20 > Perhaps I'm just running out of steam for today, but I've read this > twice, and still don't get why adding these assertions goes in the same= > patch as adding the helper, or what it has to do with events. Okay, will split this into two patches for v3. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Fqd58s6QKPPwXa9CUCnaIABLDJbPPT5um Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW13FvAAoJEKeha0olJ0NqUy0H/2JnX1PM/lWK7jXJi1g3F0DX PET266JFl8Ji4GEe+FE7EhVL/rGHnhmAUeiJfOs5eR6zjMiEm7bYO7J5NeU65OYp SozEShT6sH+8CKuP2q5whfrKwfXIc0eUvPqUXumbCNhnAYwhD1w5N/CsAXd2y3ZJ fNARH5pZ1KNBTzMaXISZ0ibWPNbOnzMh1QGkH8ZWPbOeQEvQq4Y4q9amnFCppDgk mtika0yuStwFOmLjgUO9o4TQaCYnfRT8MA7xtk4AAr3VJXlifSW/dgh4K8/kCKWK j76ZbWJbMuKwITEiTph2hjpmHsShE3X/VompO7hNai8H5MnhTxOcoXMVm/G74fY= =I0UL -----END PGP SIGNATURE----- --Fqd58s6QKPPwXa9CUCnaIABLDJbPPT5um--