From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abRHm-0003c0-Ul for qemu-devel@nongnu.org; Thu, 03 Mar 2016 06:19:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abRHi-0005ot-5q for qemu-devel@nongnu.org; Thu, 03 Mar 2016 06:19:14 -0500 References: <1456998223-12356-1-git-send-email-arei.gonglei@huawei.com> <1456998223-12356-7-git-send-email-arei.gonglei@huawei.com> From: Paolo Bonzini Message-ID: <56D81DAA.3040201@redhat.com> Date: Thu, 3 Mar 2016 12:19:06 +0100 MIME-Version: 1.0 In-Reply-To: <1456998223-12356-7-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] smbus: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org On 03/03/2016 10:43, Gonglei wrote: > Signed-off-by: Gonglei > --- > hw/i2c/smbus_eeprom.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c > index 5b7bd89..83c6b27 100644 > --- a/hw/i2c/smbus_eeprom.c > +++ b/hw/i2c/smbus_eeprom.c > @@ -156,4 +156,6 @@ void smbus_eeprom_init(I2CBus *smbus, int nb_eeprom, > qdev_prop_set_ptr(eeprom, "data", eeprom_buf + (i * 256)); > qdev_init_nofail(eeprom); > } > + > + g_free(eeprom_buf); > } > This is wrong, eeprom_buf is passed to the device through qdev_prop_set_ptr. Paolo