From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abRID-0004Kl-ME for qemu-devel@nongnu.org; Thu, 03 Mar 2016 06:19:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abRI8-000626-Rv for qemu-devel@nongnu.org; Thu, 03 Mar 2016 06:19:41 -0500 References: <1456998223-12356-1-git-send-email-arei.gonglei@huawei.com> <1456998223-12356-5-git-send-email-arei.gonglei@huawei.com> From: Paolo Bonzini Message-ID: <56D81DC5.60709@redhat.com> Date: Thu, 3 Mar 2016 12:19:33 +0100 MIME-Version: 1.0 In-Reply-To: <1456998223-12356-5-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org On 03/03/2016 10:43, Gonglei wrote: > Signed-off-by: Gonglei > --- > backends/hostmem-file.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c > index fd59482..217f858 100644 > --- a/backends/hostmem-file.c > +++ b/backends/hostmem-file.c > @@ -51,11 +51,14 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) > error_setg(errp, "-mem-path not supported on this host"); > #else > if (!memory_region_size(&backend->mr)) { > + gchar *path; > backend->force_prealloc = mem_prealloc; > + path = object_get_canonical_path(OBJECT(backend)); > memory_region_init_ram_from_file(&backend->mr, OBJECT(backend), > - object_get_canonical_path(OBJECT(backend)), > + path, > backend->size, fb->share, > fb->mem_path, errp); > + g_free(path); > } > #endif > } > Reviewed-by: Paolo Bonzini