From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59832)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1abToW-0003Tn-JU
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:01:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1abToR-0001Dl-KP
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:01:12 -0500
Received: from mx2.parallels.com ([199.115.105.18]:54008)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1abToR-0001DH-F9
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:01:07 -0500
References: <1457012886-7626-1-git-send-email-den@openvz.org>
	<56D840D4.4010109@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <56D841C6.1060303@openvz.org>
Date: Thu, 3 Mar 2016 16:53:10 +0300
MIME-Version: 1.0
In-Reply-To: <56D840D4.4010109@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from
	virt-manager to libvirt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, qemu-devel@nongnu.org, Dimitris Aragiorgis <dimara@arrikto.com>

On 03/03/2016 04:49 PM, Paolo Bonzini wrote:
>
> On 03/03/2016 14:48, Denis V. Lunev wrote:
>> libvirt in this case spawns
>>    /usr/bin/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic
>>      -M none
>>      -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait
>>      -pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize
>> and with CONFIG_TRACE_LOG this process hangs as stderr becomes redirected
>> to terminal (qemu_logfile == stderr). We do not have redirection to
>> /dev/null in this case which is necessary.
>>
>> Broken by:
>>      commit 96c33a4523ee1abe382ce4ff3e82b90ba78aa186
>>      Author: Dimitris Aragiorgis <dimara@arrikto.com>
>>      Date:   Thu Feb 18 13:38:38 2016 +0200
>>
>>      log: Redirect stderr to logfile if deamonized
>>
>> We should also take into account log filename change in runtime through
>> QMP/HMP, when the log could be even closed. In this case stderr should
>> be tweaked accordingly.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Dimitris Aragiorgis <dimara@arrikto.com>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> A patch has been posted already, and I'll send a pull request tomorrow.
>
> Paolo
I have not seen it. Can you post a link?

By the way, there are other cases fixed here, thus may be some
follow up is necessary that is why I am asking.

Den