From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abTuv-0002gM-FW for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:07:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abTur-00037D-GB for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:07:49 -0500 Received: from mga11.intel.com ([192.55.52.93]:63622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abTur-000377-AQ for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:07:45 -0500 References: <1456919441-101204-1-git-send-email-guangrong.xiao@linux.intel.com> <20160303154250-mutt-send-email-mst@redhat.com> From: Xiao Guangrong Message-ID: <56D84520.8000802@linux.intel.com> Date: Thu, 3 Mar 2016 22:07:28 +0800 MIME-Version: 1.0 In-Reply-To: <20160303154250-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/5] NVDIMM ACPI: introduce the framework of QEMU emulated DSM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 03/03/2016 09:43 PM, Michael S. Tsirkin wrote: > On Wed, Mar 02, 2016 at 07:50:36PM +0800, Xiao Guangrong wrote: >> This patchset is against commit 429fb940caadf9 (fw-cfg: support writeable >> blobs) on pci branch of Michael's git tree and can be found at: >> https://github.com/xiaogr/qemu.git nvdimm-acpi-v5 > > This looks good overall. There are some stylistic changes all over, I > think this warrants v6 with all comments addressed. Indeed. I will make the v6 to address all your comment. Thanks!