From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, Dimitris Aragiorgis <dimara@arrikto.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt
Date: Thu, 3 Mar 2016 15:15:40 +0100 [thread overview]
Message-ID: <56D8470C.5000201@redhat.com> (raw)
In-Reply-To: <56D84555.7090003@openvz.org>
On 03/03/2016 15:08, Denis V. Lunev wrote:
> On 03/03/2016 05:04 PM, Paolo Bonzini wrote:
>>
>> On 03/03/2016 14:53, Denis V. Lunev wrote:
>>>> A patch has been posted already, and I'll send a pull request tomorrow.
>>> I have not seen it. Can you post a link?
>> [PATCH] log: do not log if QEMU is daemonized but without -D
>>
>> but I found a missing case that your patch handles, so I'll post a v2
>> now.
>>
>> Paolo
>
> that is fine :) let's see. Though I think that resulted code is more
> readable in my approach.
Yes, I was going for the smallest change. Cleanups can be done on top.
Actually, the patch in v1 is fine. My worry after looking at your patch
was that I didn't have the dup2(stdout, stderr) case. However, with my
change you can never call qemu_log_close if is_daemonized(), because
even the monitor command "logfile" cannot set logfilename to NULL.
Paolo
next prev parent reply other threads:[~2016-03-03 14:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 13:48 [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt Denis V. Lunev
2016-03-03 13:49 ` Paolo Bonzini
2016-03-03 13:53 ` Denis V. Lunev
2016-03-03 14:04 ` Paolo Bonzini
2016-03-03 14:08 ` Denis V. Lunev
2016-03-03 14:15 ` Paolo Bonzini [this message]
2016-03-03 14:25 ` Denis V. Lunev
2016-03-03 14:34 ` Paolo Bonzini
2016-03-03 14:47 ` Denis V. Lunev
2016-03-03 14:53 ` Paolo Bonzini
2016-03-03 14:55 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8470C.5000201@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=dimara@arrikto.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).