From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abU2f-0007eu-80 for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:15:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abU2b-000599-1O for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:15:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abU2a-000591-Ql for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:15:44 -0500 References: <1457012886-7626-1-git-send-email-den@openvz.org> <56D840D4.4010109@redhat.com> <56D841C6.1060303@openvz.org> <56D84487.5070009@redhat.com> <56D84555.7090003@openvz.org> From: Paolo Bonzini Message-ID: <56D8470C.5000201@redhat.com> Date: Thu, 3 Mar 2016 15:15:40 +0100 MIME-Version: 1.0 In-Reply-To: <56D84555.7090003@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Dimitris Aragiorgis On 03/03/2016 15:08, Denis V. Lunev wrote: > On 03/03/2016 05:04 PM, Paolo Bonzini wrote: >> >> On 03/03/2016 14:53, Denis V. Lunev wrote: >>>> A patch has been posted already, and I'll send a pull request tomorrow. >>> I have not seen it. Can you post a link? >> [PATCH] log: do not log if QEMU is daemonized but without -D >> >> but I found a missing case that your patch handles, so I'll post a v2 >> now. >> >> Paolo > > that is fine :) let's see. Though I think that resulted code is more > readable in my approach. Yes, I was going for the smallest change. Cleanups can be done on top. Actually, the patch in v1 is fine. My worry after looking at your patch was that I didn't have the dup2(stdout, stderr) case. However, with my change you can never call qemu_log_close if is_daemonized(), because even the monitor command "logfile" cannot set logfilename to NULL. Paolo