From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, Dimitris Aragiorgis <dimara@arrikto.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt
Date: Thu, 3 Mar 2016 15:53:48 +0100 [thread overview]
Message-ID: <56D84FFC.5040803@redhat.com> (raw)
In-Reply-To: <56D84E93.90904@openvz.org>
On 03/03/2016 15:47, Denis V. Lunev wrote:
>>
> ok, you are finally right. Your original code is correct and will
> work even in these corner case.
>
> Will it make sense to send a patch which will replace that code
> to my one as followup + fix if 'fopen' will fail?
Definitely. While at it, you could move qemu_log_close and
qemu_log_flush from the header to the C file. They are in the header
only for very historical reasons; exec.c in the past could only invoke a
limited amount of external code, but luckily that's not the case anymore.
Paolo
next prev parent reply other threads:[~2016-03-03 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 13:48 [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt Denis V. Lunev
2016-03-03 13:49 ` Paolo Bonzini
2016-03-03 13:53 ` Denis V. Lunev
2016-03-03 14:04 ` Paolo Bonzini
2016-03-03 14:08 ` Denis V. Lunev
2016-03-03 14:15 ` Paolo Bonzini
2016-03-03 14:25 ` Denis V. Lunev
2016-03-03 14:34 ` Paolo Bonzini
2016-03-03 14:47 ` Denis V. Lunev
2016-03-03 14:53 ` Paolo Bonzini [this message]
2016-03-03 14:55 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D84FFC.5040803@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=dimara@arrikto.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).