From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abUdY-0005iF-Rc for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:53:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abUdU-0006fK-Hc for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:53:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abUdU-0006f5-C1 for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:53:52 -0500 References: <1457012886-7626-1-git-send-email-den@openvz.org> <56D840D4.4010109@redhat.com> <56D841C6.1060303@openvz.org> <56D84487.5070009@redhat.com> <56D84555.7090003@openvz.org> <56D8470C.5000201@redhat.com> <56D84955.6070508@openvz.org> <56D84B85.70408@redhat.com> <56D84E93.90904@openvz.org> From: Paolo Bonzini Message-ID: <56D84FFC.5040803@redhat.com> Date: Thu, 3 Mar 2016 15:53:48 +0100 MIME-Version: 1.0 In-Reply-To: <56D84E93.90904@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Dimitris Aragiorgis On 03/03/2016 15:47, Denis V. Lunev wrote: >> > ok, you are finally right. Your original code is correct and will > work even in these corner case. > > Will it make sense to send a patch which will replace that code > to my one as followup + fix if 'fopen' will fail? Definitely. While at it, you could move qemu_log_close and qemu_log_flush from the header to the C file. They are in the header only for very historical reasons; exec.c in the past could only invoke a limited amount of external code, but luckily that's not the case anymore. Paolo