From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44569)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1abUf2-0007if-HT
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:55:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1abUez-00076L-D0
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:55:28 -0500
Received: from mx2.parallels.com ([199.115.105.18]:49974)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1abUez-000769-7K
	for qemu-devel@nongnu.org; Thu, 03 Mar 2016 09:55:25 -0500
References: <1457012886-7626-1-git-send-email-den@openvz.org>
	<56D840D4.4010109@redhat.com> <56D841C6.1060303@openvz.org>
	<56D84487.5070009@redhat.com> <56D84555.7090003@openvz.org>
	<56D8470C.5000201@redhat.com> <56D84955.6070508@openvz.org>
	<56D84B85.70408@redhat.com> <56D84E93.90904@openvz.org>
	<56D84FFC.5040803@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <56D85055.1070408@openvz.org>
Date: Thu, 3 Mar 2016 17:55:17 +0300
MIME-Version: 1.0
In-Reply-To: <56D84FFC.5040803@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from
	virt-manager to libvirt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, qemu-devel@nongnu.org, Dimitris Aragiorgis <dimara@arrikto.com>

On 03/03/2016 05:53 PM, Paolo Bonzini wrote:
>
> On 03/03/2016 15:47, Denis V. Lunev wrote:
>> ok, you are finally right. Your original code is correct and will
>> work even in these corner case.
>>
>> Will it make sense to send a patch which will replace that code
>> to my one as followup + fix if 'fopen' will fail?
> Definitely.  While at it, you could move qemu_log_close and
> qemu_log_flush from the header to the C file.  They are in the header
> only for very historical reasons; exec.c in the past could only invoke a
> limited amount of external code, but luckily that's not the case anymore.
>
> Paolo
got this. thank you :)