From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org,
david@gibson.dropbear.id.au, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
Date: Fri, 4 Mar 2016 16:42:45 +0800 [thread overview]
Message-ID: <56D94A85.2030202@cn.fujitsu.com> (raw)
In-Reply-To: <20160303145949.1f89d33c@nial.brq.redhat.com>
On 03/03/2016 09:59 PM, Igor Mammedov wrote:
> On Thu, 3 Mar 2016 17:24:12 +0800
> Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
>
>> correct comment and remove an unused macro. commit adcb4ee6 already
>> correct its type
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
>
>> ---
>> Btw, in pc_memory_init(), I don`t see in which condition, the following code
>> will be executed:
>>
>> if ((pcms->hotplug_memory.base + hotplug_mem_size) <
>> hotplug_mem_size) {
>> error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT,
>> machine->maxram_size);
>> exit(EXIT_FAILURE);
>> }
>>
>> I appreciate if anyone could give a hint
> Integer overflow?
>
Ah yes, make sense. Thanks very much for the hint
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-03-04 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 9:24 [Qemu-devel] [PATCH] correct comment of MemoryHotplugState Cao jin
2016-03-03 13:59 ` Igor Mammedov
2016-03-04 8:42 ` Cao jin [this message]
2016-03-14 5:42 ` Cao jin
2016-03-15 20:00 ` Eduardo Habkost
2016-04-09 9:18 ` Cao jin
2016-04-12 18:49 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D94A85.2030202@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).