From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abs2U-0000Vq-NN for qemu-devel@nongnu.org; Fri, 04 Mar 2016 10:53:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abs2R-0008R9-Az for qemu-devel@nongnu.org; Fri, 04 Mar 2016 10:53:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abs2R-0008R5-5T for qemu-devel@nongnu.org; Fri, 04 Mar 2016 10:53:11 -0500 References: <1457103235-3341-1-git-send-email-sarahjmi07@gmail.com> <56D9AD78.8070802@redhat.com> <56D9AE85.7040604@redhat.com> From: Eric Blake Message-ID: <56D9AF65.4030108@redhat.com> Date: Fri, 4 Mar 2016 08:53:09 -0700 MIME-Version: 1.0 In-Reply-To: <56D9AE85.7040604@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pStDUR6CgeO86bUx2gHs1fs5X0k6NLtbW" Subject: Re: [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sarah Khan , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pStDUR6CgeO86bUx2gHs1fs5X0k6NLtbW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/04/2016 08:49 AM, Eric Blake wrote: > Oh, I see you DID include a S-o-b, but in the subject line of the patch= > instead of the commit body. Which still needs work. You need a > one-line summary as the subject, not your S-o-b, so the commit message > should look more like: >=20 > thunk: Replace malloc with g_malloc() >=20 > This replacement was suggested as part of the bite-sized tasks. >=20 > Signed-off-by: Sarah Khan Oh, and I'd be remiss if I did not add: This looks like your first contribution. Welcome to the QEMU community, and hope you enjoy it here! Keep in mind that email is a bad medium for expressing emotion, and that reviewers tend to point out flaws without looking for the good; but in reality, we are grateful when someone steps up to help with the bite-sized tasks. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pStDUR6CgeO86bUx2gHs1fs5X0k6NLtbW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW2a9mAAoJEKeha0olJ0NqNfsH/0zDG/AUjZtoRyAWWbJ+he4t nOUcrV3CyC/qXK00fU5ULtCd0Gr4xKxaTKBaxbS/Hg33JvkVCTgQXBfa+ZMoxtOf fZw2vwlP0pTaRUqiNXgyvOSIDjjIlWzoUt3VcGVCstapEHud9k0LslTHqPN9rtY0 Kim/YijwuNCQAUNmtfU3IJf9K8TyBQ0Rtba20CqNIRnT73p38q23RwxA1bEFFX/B D7ZA+aOpaJpcD7r5AgvXM2eF8kJ3HWibUaReXMWhKyDynQUqXgXxE+it5Jwkh1Hv mpIYRI+4DhCNN7IJEgg+5kXIuR6t0OnY7k9sSiGcG4ecBJHiEAW71N9ghMmNu/o= =aOpz -----END PGP SIGNATURE----- --pStDUR6CgeO86bUx2gHs1fs5X0k6NLtbW--