From: Richard Henderson <rth@twiddle.net>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, crosthwaitepeter@gmail.com, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH v8 5/9] qemu-log: new option -dfilter to limit output
Date: Sat, 5 Mar 2016 06:17:38 -0800 [thread overview]
Message-ID: <56DAEA82.2070202@twiddle.net> (raw)
In-Reply-To: <1457090287-8021-6-git-send-email-alex.bennee@linaro.org>
On 03/04/2016 03:18 AM, Alex Bennée wrote:
> + case '+':
> + {
> + unsigned long len;
> + err |= qemu_strtoull(r2, NULL, 0, &len);
> + if (len > 0) {
> + range.end = range.begin + (len - 1);
> + } else {
> + err |= true;
> + }
> + break;
> + }
> + case '-':
> + {
> + unsigned long len;
> + err |= qemu_strtoull(r2, NULL, 0, &len);
> + range.end = range.begin;
> + range.begin = range.end - len;
> + break;
> + }
Doesn't '-' have the same off-by-one bug?
Although really I don't understand the need for negative ranges...
r~
next prev parent reply other threads:[~2016-03-05 14:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 11:17 [Qemu-devel] [PATCH v8 0/9] qemu-log, -dfilter and other logging tweaks Alex Bennée
2016-03-04 11:17 ` [Qemu-devel] [PATCH v8 1/9] tcg: pass down TranslationBlock to tcg_code_gen Alex Bennée
2016-03-04 11:18 ` [Qemu-devel] [PATCH v8 2/9] qemu-log: correct help text for -d cpu Alex Bennée
2016-03-04 11:18 ` [Qemu-devel] [PATCH v8 3/9] qemu-log: Avoid function call for disabled qemu_log_mask logging Alex Bennée
2016-03-04 11:18 ` [Qemu-devel] [PATCH v8 4/9] qemu-log: Improve the "exec" TB execution logging Alex Bennée
2016-03-04 11:18 ` [Qemu-devel] [PATCH v8 5/9] qemu-log: new option -dfilter to limit output Alex Bennée
2016-03-05 14:17 ` Richard Henderson [this message]
2016-03-14 17:24 ` Alex Bennée
2016-03-04 11:18 ` [Qemu-devel] [PATCH v8 6/9] qemu-log: dfilter-ise exec, out_asm, op and opt_op Alex Bennée
2016-03-04 11:18 ` [Qemu-devel] [PATCH v8 7/9] target-arm: dfilter support for in_asm Alex Bennée
2016-03-04 11:18 ` [Qemu-devel] [PATCH v8 8/9] qemu-log: support simple pid substitution for logs Alex Bennée
2016-03-04 11:18 ` [Qemu-devel] [PATCH v8 9/9] cputlb: modernise the debug support Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DAEA82.2070202@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crosthwaitepeter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).