From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1acD1f-0008QV-Bp
	for qemu-devel@nongnu.org; Sat, 05 Mar 2016 09:17:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1acD1b-0002Ux-8u
	for qemu-devel@nongnu.org; Sat, 05 Mar 2016 09:17:47 -0500
Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:36318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1acD1b-0002Ut-5L
	for qemu-devel@nongnu.org; Sat, 05 Mar 2016 09:17:43 -0500
Received: by mail-qk0-x243.google.com with SMTP id e124so2648594qkc.3
	for <qemu-devel@nongnu.org>; Sat, 05 Mar 2016 06:17:42 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1457090287-8021-1-git-send-email-alex.bennee@linaro.org>
	<1457090287-8021-6-git-send-email-alex.bennee@linaro.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56DAEA82.2070202@twiddle.net>
Date: Sat, 5 Mar 2016 06:17:38 -0800
MIME-Version: 1.0
In-Reply-To: <1457090287-8021-6-git-send-email-alex.bennee@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v8 5/9] qemu-log: new option -dfilter to
	limit output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, crosthwaitepeter@gmail.com, aurelien@aurel32.net

On 03/04/2016 03:18 AM, Alex Bennée wrote:
> +                case '+':
> +                {
> +                    unsigned long len;
> +                    err |= qemu_strtoull(r2, NULL, 0, &len);
> +                    if (len > 0) {
> +                        range.end = range.begin + (len - 1);
> +                    } else {
> +                        err |= true;
> +                    }
> +                    break;
> +                }
> +                case '-':
> +                {
> +                    unsigned long len;
> +                    err |= qemu_strtoull(r2, NULL, 0, &len);
> +                    range.end = range.begin;
> +                    range.begin = range.end - len;
> +                    break;
> +                }

Doesn't '-' have the same off-by-one bug?
Although really I don't understand the need for negative ranges...


r~