From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acM9R-0001ER-5u for qemu-devel@nongnu.org; Sat, 05 Mar 2016 19:02:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acM9N-0000Em-UM for qemu-devel@nongnu.org; Sat, 05 Mar 2016 19:02:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acM9N-0000Ei-Mo for qemu-devel@nongnu.org; Sat, 05 Mar 2016 19:02:21 -0500 References: <065EA09A-157B-4F3A-BEFC-7C71F8020DC9@gmail.com> From: Eric Blake Message-ID: <56DB738C.3040204@redhat.com> Date: Sat, 5 Mar 2016 17:02:20 -0700 MIME-Version: 1.0 In-Reply-To: <065EA09A-157B-4F3A-BEFC-7C71F8020DC9@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UAQXOjX0qqwtlwThtufaKqjL6vc4igxWe" Subject: Re: [Qemu-devel] [PATCH v3 1/4] adb-keys.h: initial commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid , Peter Maydell , Gerd Hoffmann Cc: qemu-devel qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UAQXOjX0qqwtlwThtufaKqjL6vc4igxWe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/04/2016 10:15 PM, Programmingkid wrote: > This commit implements the adb-keys.h file. It holds information on adb= keycode > values. >=20 > Signed-off-by: John Arbuckle > --- > Changed name of file from MacKeys.h to adb-keys.h. > Changed name of constants from MAC_KEYS_ to ADB_KEYS_.=20 >=20 > include/hw/input/adb-keys.h | 160 ++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 160 insertions(+) > create mode 100644 include/hw/input/adb-keys.h Thanks; you're getting closer at decent submission style. Your threading is still broken, though (the mail is missing an 'In-Reply-To:' header that refers to from the 0/4 cover letter); you can see this in the list archives: https://lists.gnu.org/archive/html/qemu-devel/2016-03/threads.html#01180 Note how your messages each appear as top-level threads, while most other series are properly threaded. >=20 > diff --git a/include/hw/input/adb-keys.h b/include/hw/input/adb-keys.h > new file mode 100644 > index 0000000..6e009ee > --- /dev/null > +++ b/include/hw/input/adb-keys.h > @@ -0,0 +1,160 @@ > +/* > + * QEMU System Emulator > + * > + * Copyright (c) 2003-2008 Fabrice Bellard Fabrice did not write this file. You're probably better off replacing this line wholesale with a Copyright 2016 and claiming copyright yourself, since it is new material from you that is not substantially copied from some existing file. > + * > + * Permission is hereby granted, free of charge, to any person obtaini= ng a copy > + * of this software and associated documentation files (the "Software"= ), to deal > + * in the Software without restriction, including without limitation t= he rights > + * to use, copy, modify, merge, publish, distribute, sublicense, and/o= r sell > + * copies of the Software, and to permit persons to whom the Software = is > + * furnished to do so, subject to the following conditions: Any reason you chose the weaker BSD license instead of the project-default of GPLv2+? > +/* > + * adb-keys.h > + * > + * Provides a enum of all the Macintosh keycodes. s/a enum/an enum/ Can you provide a URL to the source document that you used for coming up with this list, so that we can better double-check your work? (Do it as a comment in this file, if you have one) > + * Note: keys like Power, volume related, and eject are handled at a = lower > + * level and are not available to QEMU. That doesn't mean we ca= n't > + * substitute one key for another. The function keys like F1 ma= ke a good > + * substitute for these keys. This can be done in the GTK, SDL,= or Cocoa > + * code. > + */ > + > +#ifndef __ADBKEYS__ > +#define __ADBKEYS__ The name '__ADBKEYS__' is reserved for the compiler's use; you risk a future collision for no good reason. It's fine to use 'ADB_KEYS_H' as your witness, better matching your filename and staying out of reserved namespace. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UAQXOjX0qqwtlwThtufaKqjL6vc4igxWe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW23OMAAoJEKeha0olJ0NqOysH/3+3Ble4xirVxUakUMmYE3sg CU3uf9nUTECsqP8rapCvPRfRg8M6cOLyIsGxO+5Td2JVEEFffqk3fu4+4rB8BXGw tt58tqLAQXZI9E8E3LVbKRTcPL0pNJqwyIKRh5lergIo4YgBIgTrl5avvEOhRHP2 JeBRypIWjYl+dQNSimVoq5cPxok85VUhLZ/V8CNIV/612wbPYSJn5vxO9b3pOfOf WNXsctwsw41NjIc/XKEz9z8GudiZgHwH7YyAVNbOFxw9WnGLe4uUfpToxBHaJ58T IigfGz9DyuJQ4dEs3wZ17dmWmJNaHU59/hupOyxG64VlCh8CGj12SPzoj7h3FaA= =RwQy -----END PGP SIGNATURE----- --UAQXOjX0qqwtlwThtufaKqjL6vc4igxWe--