From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54951)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1acp5K-00071w-01
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 01:56:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1acp5F-0001vd-1Y
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 01:56:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35175)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1acp5E-0001vY-SG
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 01:56:00 -0500
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<a6425369450ce7a2e47cadc2e6f714bcb42cd190.1456168872.git.samuel.thibault@ens-lyon.org>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56DD25F8.9010602@redhat.com>
Date: Mon, 7 Mar 2016 14:55:52 +0800
MIME-Version: 1.0
In-Reply-To: <a6425369450ce7a2e47cadc2e6f714bcb42cd190.1456168872.git.samuel.thibault@ens-lyon.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv9 02/10] slirp: Adding ICMPv6 error sending
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, Huangpeng <peter.huangpeng@huawei.com>, Yann Bordenave <meow@meowstars.org>, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Guillaume Subiron <maethor@subiron.org>



On 02/23/2016 03:28 AM, Samuel Thibault wrote:
> From: Yann Bordenave <meow@meowstars.org>
>
> Disambiguation : icmp_error is renamed into icmp_send_error, since it
> doesn't manage errors, but only sends ICMP Error messages.
>
> Adding icmp6_send_error to send ICMPv6 Error messages. This function is
> simpler than the v4 version.
> Adding some calls in various functions to send ICMP errors, when a
> received packet is too big, or when its hop limit is 0.

Let's split this into two patches to avoid mixing renaming and new
function introduction.