From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Amit Shah <amit.shah@redhat.com>
Cc: "Denis V. Lunev" <den@openvz.org>,
Peter Maydell <peter.maydell@linaro.org>,
qemu list <qemu-devel@nongnu.org>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PULL 2/5] migration: move bdrv_invalidate_cache_all of of coroutine context
Date: Mon, 7 Mar 2016 14:30:21 +0100 [thread overview]
Message-ID: <56DD826D.5090306@redhat.com> (raw)
In-Reply-To: <20160307124911.GB2253@work-vm>
On 07/03/2016 13:49, Dr. David Alan Gilbert wrote:
> b) The harder problem is that there's a race where qemu_bh_delete
> segs, and I'm not 100% sure why yet - it only does it sometime
> (i.e. run virt-test and leave it and it occasionally does it).
> From the core it looks like qemu->bh is corrupt (0x10101010...)
> so maybe mis has been freed at that point?
> I'm suspecting this is the postcopy_ram_listen_thread freeing
> mis at the end of it, but I don't know yet.
That should be it. Maybe the patch can simply be reverted, because
loadvm_postcopy_handle_run runs from a thread and not a coroutine. Is
this correct?
However I have a bug or two for you to fix, too:
1) as far as I can see, postcopy_ram_listen_thread is not holding the
mutex during the call to qemu_loadvm_state_main. Is that a bug?
2) no one is currently joining mis->listen_thread, I suspect it actually
should be QEMU_THREAD_DETACHED.
:)
Paolo
next prev parent reply other threads:[~2016-03-07 13:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 7:30 [Qemu-devel] [PULL 0/5] migration pull Amit Shah
2016-02-23 7:30 ` [Qemu-devel] [PULL 1/5] migration: move bdrv_invalidate_cache_all of of coroutine context Amit Shah
2016-02-23 7:30 ` [Qemu-devel] [PULL 2/5] " Amit Shah
2016-03-07 12:49 ` Dr. David Alan Gilbert
2016-03-07 13:30 ` Paolo Bonzini [this message]
2016-03-07 18:06 ` Dr. David Alan Gilbert
2016-03-07 18:58 ` Denis V. Lunev
2016-03-08 10:45 ` Dr. David Alan Gilbert
2016-03-08 10:54 ` Denis V. Lunev
2016-02-23 7:30 ` [Qemu-devel] [PULL 3/5] migration: reorder code to make it symmetric Amit Shah
2016-02-23 7:30 ` [Qemu-devel] [PULL 4/5] configure: detect ifunc and avx2 attribute Amit Shah
2016-02-23 7:30 ` [Qemu-devel] [PULL 5/5] cutils: add avx2 instruction optimization Amit Shah
2016-02-23 9:09 ` [Qemu-devel] [PULL 0/5] migration pull Peter Maydell
2016-02-23 9:38 ` Amit Shah
2016-02-23 9:48 ` Paolo Bonzini
2016-02-23 10:43 ` Peter Maydell
2016-02-23 11:18 ` Li, Liang Z
2016-02-23 11:25 ` Peter Maydell
2016-02-23 14:04 ` Paolo Bonzini
2016-02-24 9:27 ` Li, Liang Z
2016-03-08 4:23 ` Amit Shah
2016-03-08 4:28 ` Li, Liang Z
2016-02-23 9:55 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DD826D.5090306@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).