From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acvF3-0005Wx-5e for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:30:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acvEx-0001nh-HT for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:30:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acvEx-0001nR-BT for qemu-devel@nongnu.org; Mon, 07 Mar 2016 08:30:27 -0500 References: <33f7c8c309e6625942e6b8548faa96606a6f99b1.1456212545.git.amit.shah@redhat.com> <20160307124911.GB2253@work-vm> From: Paolo Bonzini Message-ID: <56DD826D.5090306@redhat.com> Date: Mon, 7 Mar 2016 14:30:21 +0100 MIME-Version: 1.0 In-Reply-To: <20160307124911.GB2253@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 2/5] migration: move bdrv_invalidate_cache_all of of coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Amit Shah Cc: "Denis V. Lunev" , Peter Maydell , qemu list , Juan Quintela On 07/03/2016 13:49, Dr. David Alan Gilbert wrote: > b) The harder problem is that there's a race where qemu_bh_delete > segs, and I'm not 100% sure why yet - it only does it sometime > (i.e. run virt-test and leave it and it occasionally does it). > From the core it looks like qemu->bh is corrupt (0x10101010...) > so maybe mis has been freed at that point? > I'm suspecting this is the postcopy_ram_listen_thread freeing > mis at the end of it, but I don't know yet. That should be it. Maybe the patch can simply be reverted, because loadvm_postcopy_handle_run runs from a thread and not a coroutine. Is this correct? However I have a bug or two for you to fix, too: 1) as far as I can see, postcopy_ram_listen_thread is not holding the mutex during the call to qemu_loadvm_state_main. Is that a bug? 2) no one is currently joining mis->listen_thread, I suspect it actually should be QEMU_THREAD_DETACHED. :) Paolo