From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39805)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1acxEY-00013k-Ol
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 10:38:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1acxET-0001yc-MR
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 10:38:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44117)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1acxET-0001yI-HX
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 10:38:05 -0500
References: <cover.1456168872.git.samuel.thibault@ens-lyon.org>
	<56DD2430.2090509@redhat.com>
	<20160307115508.GJ5169@var.bordeaux.inria.fr>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <56DDA057.2080107@redhat.com>
Date: Mon, 7 Mar 2016 16:37:59 +0100
MIME-Version: 1.0
In-Reply-To: <20160307115508.GJ5169@var.bordeaux.inria.fr>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu
 -net user mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>, Jason Wang <jasowang@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Guillaume Subiron <maethor@subiron.org>

On 07.03.2016 12:55, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote:
>> - the series does not build on w32:
>> In file included from ./slirp/slirp.h:126:0,
>>                  from stubs/slirp.c:3:
>> ./slirp/ip6.h:9:24: fatal error: netinet/in.h: No such file or directo=
ry
>=20
> Is it the only issue?  Does it build if you add #ifndef _WIN32 around
> that include?

Is that "#include <netinet/in.h>" required in ip6.h at all? It also seems
to compile if I omit that include completely here...

Anyway, I just tried with my mingw32 cross-compiler, and once this is fix=
ed,
compilation succeeds, but there are some warnings:

net/slirp.c: In function 'net_slirp_init':
net/slirp.c:249:5: warning: implicit declaration of function 'inet_pton' =
[-Wimplicit-function-declaration]
     if (!inet_pton(AF_INET6, vprefix6, &ip6_prefix)) {
     ^
slirp/ip6_icmp.c: In function 'icmp6_send_error':
slirp/ip6_icmp.c:84:5: warning: implicit declaration of function 'inet_nt=
op' [-Wimplicit-function-declaration]
     inet_ntop(AF_INET6, &rip->ip_dst, addrstr, INET6_ADDRSTRLEN);
     ^
qemu/slirp/ndp_table.c: In function 'ndp_table_add':
qemu/slirp/ndp_table.c:16:5: warning: implicit declaration of function 'i=
net_ntop' [-Wimplicit-function-declaration]
     inet_ntop(AF_INET6, &(ip_addr), addrstr, INET6_ADDRSTRLEN);

The warnings go away when I use this piece of code in the beginning of th=
e affected files:

#ifdef _WIN32
#define _WIN32_WINNT _WIN32_WINNT_WIN6=20
#include <ws2tcpip.h>
#endif

 Thomas