From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1acxbv-0008Q7-SB
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:02:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1acxbv-0001rj-0h
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:02:19 -0500
References: <1455615450-15138-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1455615450-15138-3-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<56DB21B7.7050104@redhat.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <56DDA5FF.2050900@redhat.com>
Date: Mon, 7 Mar 2016 09:02:07 -0700
MIME-Version: 1.0
In-Reply-To: <56DB21B7.7050104@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="Mbmx1LqJbLbQWUtDae6agINrsvtvJr5GH"
Subject: Re: [Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child()
 and bdrv_del_child()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, Changlong Xie <xiecl.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu block <qemu-block@nongnu.org>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Mbmx1LqJbLbQWUtDae6agINrsvtvJr5GH
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 03/05/2016 11:13 AM, Max Reitz wrote:

>> +    index =3D atoi(child->name + 9);
>=20
> Optional: Assert absence of an error:
>=20

Indeed, atoi() is worthless, because it cannot do error detection.

> unsigned long index;
> char *endptr;
>=20
> index =3D strtoul(child->name + 9, &endptr, 10);
> assert(index >=3D 0 && !*endptr);

Still incorrect; you aren't handling errno properly for detecting all
errors.  Even better is to use qemu_strtoul(), which already handles
proper error detection.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--Mbmx1LqJbLbQWUtDae6agINrsvtvJr5GH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJW3aX/AAoJEKeha0olJ0Nq4Y0H/1U4EW+v4F14GEBQYljyaltz
MOy0XBNxFSksW5ToGeFCNIfa4z3HPw1B1jFmxpgqf2myjS/hECgjit6cerOkhLBO
l1hpy4pXfQhGj0wBa3o6MOIFi2SyNsdFlTeG1X7XqStYSdtMP/4QZF+YOxxllJUG
13Z8/mGnXV8fZQUFeeSvsl8+8JaUwkXcsI6FvnkajEhN17NPe4s1/tvrBkQZN7ye
LkQmwdRpYtxQCmChAg4ruq0pzEgvVgpvLiNjOYaylYYu5v5WZZJkUmx3UJM+rnQP
ZonDbiOlLnB8SrofrfyCOuhdQ6rKYZtdFp11Uxo4I4LpEqKFmGfs0UhAVvOinlo=
=ZEDa
-----END PGP SIGNATURE-----

--Mbmx1LqJbLbQWUtDae6agINrsvtvJr5GH--