From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acxfO-00043r-U1 for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:05:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acxfK-0002t6-1N for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:05:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acxfJ-0002sz-Jy for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:05:49 -0500 References: <56DD2821.6020405@redhat.com> <20160307114153.GG5169@var.bordeaux.inria.fr> From: Eric Blake Message-ID: <56DDA6DA.8040402@redhat.com> Date: Mon, 7 Mar 2016 09:05:46 -0700 MIME-Version: 1.0 In-Reply-To: <20160307114153.GG5169@var.bordeaux.inria.fr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CpgnNDdvg1eA5MTGR7kJGInQNeEAr1XG2" Subject: Re: [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , Jason Wang Cc: Thomas Huth , zhanghailiang , Li Zhijian , Stefan Hajnoczi , qemu-devel@nongnu.org, Vasiliy Tolstov , Dave Gilbert , Yann Bordenave , Gonglei , Jan Kiszka , Huangpeng , Guillaume Subiron This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CpgnNDdvg1eA5MTGR7kJGInQNeEAr1XG2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/07/2016 04:41 AM, Samuel Thibault wrote: > Jason Wang, on Mon 07 Mar 2016 15:05:05 +0800, wrote: >> Please do unnecessary changes like this since it will cause extra effo= rt >> for git blame and other things. >=20 > Ok. I just do hope that no other reviewer will come and say that we > should fix the alignment of the parameters. Alignment doesn't matter; in fact, most qapi .json files use 'name': 'type with a single space after : for every parameter, rather than trying to align things. It doesn't bother me either way (or I would have pointed it out sooner), but reindenting is more churn than I would personally do.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CpgnNDdvg1eA5MTGR7kJGInQNeEAr1XG2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW3abaAAoJEKeha0olJ0NqZXwH/2xtDMe0qtYuvVCYoEWG4R5R jctiG/OVGOoox9ukqqAO70LoklqPcVdNOmKkTvKiMqNykRqkakLVxw3qJ/O5PbDn 5OtZCZSTJVjj6N0qzycpe+xeTjLPgC5nrRszmTxOrutDEnLz7lkd2+Q56y4WkdzK Eyqhn7b4rEl1edVYSiFYpJt/CkOVVrUiBSddBrjXTlS68Hu8o8QJeAQXa9DAg2aC P1VetZmCkGUf1W7kmIocvOkfbuUgOwX37DhGaylP+CWhHMWzgNwy2ImS+o+riaRt t2t4qbA4taxMsZHadbAVBp4iUrRFtgCSKjCVjhBS32vj/bzsjXAMEQI31wmFqvk= =koEy -----END PGP SIGNATURE----- --CpgnNDdvg1eA5MTGR7kJGInQNeEAr1XG2--