From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58761)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1acy8f-0002vq-AC
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:36:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1acy8a-00045O-AV
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:36:09 -0500
Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:37113)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1acy8a-00044B-0o
	for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:36:04 -0500
Received: from localhost
	by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <frankja@linux.vnet.ibm.com>;
	Mon, 7 Mar 2016 16:36:01 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6161F1B08019
	for <qemu-devel@nongnu.org>; Mon,  7 Mar 2016 16:36:24 +0000 (GMT)
Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com
	[9.149.37.216])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u27GZxbo4391270
	for <qemu-devel@nongnu.org>; Mon, 7 Mar 2016 16:35:59 GMT
Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u27GZw1p013863
	for <qemu-devel@nongnu.org>; Mon, 7 Mar 2016 09:35:59 -0700
References: <1456813104-25902-5-git-send-email-famz@redhat.com>
	<1457342271-13410-1-git-send-email-famz@redhat.com>
From: Janosch Frank <frankja@linux.vnet.ibm.com>
Message-ID: <56DDADEE.4020204@linux.vnet.ibm.com>
Date: Mon, 7 Mar 2016 17:35:58 +0100
MIME-Version: 1.0
In-Reply-To: <1457342271-13410-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for
 MemoryRegion.ram_block removal
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Laszlo Ersek <lersek@redhat.com>, Peter Xu <peterx@redhat.com>

On 03/07/2016 10:17 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> 
> This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or
> squashed into it if we want strict synchronization).
> ---
>  scripts/dump-guest-memory.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> index f274bf8..c0a2e99 100644
> --- a/scripts/dump-guest-memory.py
> +++ b/scripts/dump-guest-memory.py
> @@ -352,7 +352,7 @@ def memory_region_get_ram_ptr(memory_region):
>          return (memory_region_get_ram_ptr(memory_region["alias"].dereference())
>                  + memory_region["alias_offset"])
> 
> -    return qemu_get_ram_ptr(memory_region["ram_addr"] & TARGET_PAGE_MASK)
> +    return qemu_get_ram_ptr(memory_region["ram_block"]["offset"])

If you get rid of TARGET_PAGE_MASK you might also want to get rid of its
definition, we only use it once.

I only had a short look, I'll look through your patches tomorrow morning.

Cheers
> 
> 
>  def get_guest_phys_blocks():
>