From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Pyrgiotis <apyrgio@arrikto.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi-bus: Remove tape command from scsi_req_xfer
Date: Mon, 7 Mar 2016 17:56:31 +0100 [thread overview]
Message-ID: <56DDB2BF.9070208@redhat.com> (raw)
In-Reply-To: <1457365822-22435-1-git-send-email-apyrgio@arrikto.com>
On 07/03/2016 16:50, Alex Pyrgiotis wrote:
> Remove the RECOVER_BUFFERED_DATA command from the list of commands that
> are handled by scsi_req_xfer(). Given that this command is
> tape-specific, it should be handled only by scsi_stream_req_xfer().
>
> Signed-off-by: Alex Pyrgiotis <apyrgio@arrikto.com>
>
> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
> index 6dcdbc0..a21752b 100644
> --- a/hw/scsi/scsi-bus.c
> +++ b/hw/scsi/scsi-bus.c
> @@ -989,7 +989,6 @@ static int scsi_req_xfer(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf)
> }
> /* fall through */
> case READ_10:
> - case RECOVER_BUFFERED_DATA:
> case READ_12:
> case READ_16:
> cmd->xfer *= dev->blocksize;
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2016-03-07 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 15:50 [Qemu-devel] [PATCH] scsi-bus: Remove tape command from scsi_req_xfer Alex Pyrgiotis
2016-03-07 16:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DDB2BF.9070208@redhat.com \
--to=pbonzini@redhat.com \
--cc=apyrgio@arrikto.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).