From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acySV-0001MM-9T for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:56:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acySR-0000xo-9M for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:56:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acySR-0000xj-3I for qemu-devel@nongnu.org; Mon, 07 Mar 2016 11:56:35 -0500 References: <1457365822-22435-1-git-send-email-apyrgio@arrikto.com> From: Paolo Bonzini Message-ID: <56DDB2BF.9070208@redhat.com> Date: Mon, 7 Mar 2016 17:56:31 +0100 MIME-Version: 1.0 In-Reply-To: <1457365822-22435-1-git-send-email-apyrgio@arrikto.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi-bus: Remove tape command from scsi_req_xfer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Pyrgiotis , qemu-devel@nongnu.org On 07/03/2016 16:50, Alex Pyrgiotis wrote: > Remove the RECOVER_BUFFERED_DATA command from the list of commands that > are handled by scsi_req_xfer(). Given that this command is > tape-specific, it should be handled only by scsi_stream_req_xfer(). > > Signed-off-by: Alex Pyrgiotis > > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c > index 6dcdbc0..a21752b 100644 > --- a/hw/scsi/scsi-bus.c > +++ b/hw/scsi/scsi-bus.c > @@ -989,7 +989,6 @@ static int scsi_req_xfer(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf) > } > /* fall through */ > case READ_10: > - case RECOVER_BUFFERED_DATA: > case READ_12: > case READ_16: > cmd->xfer *= dev->blocksize; > Queued, thanks. Paolo