* [Qemu-devel] [PATCH] scsi-bus: Remove tape command from scsi_req_xfer
@ 2016-03-07 15:50 Alex Pyrgiotis
2016-03-07 16:56 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Alex Pyrgiotis @ 2016-03-07 15:50 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini
Remove the RECOVER_BUFFERED_DATA command from the list of commands that
are handled by scsi_req_xfer(). Given that this command is
tape-specific, it should be handled only by scsi_stream_req_xfer().
Signed-off-by: Alex Pyrgiotis <apyrgio@arrikto.com>
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index 6dcdbc0..a21752b 100644
--- a/hw/scsi/scsi-bus.c
+++ b/hw/scsi/scsi-bus.c
@@ -989,7 +989,6 @@ static int scsi_req_xfer(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf)
}
/* fall through */
case READ_10:
- case RECOVER_BUFFERED_DATA:
case READ_12:
case READ_16:
cmd->xfer *= dev->blocksize;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] scsi-bus: Remove tape command from scsi_req_xfer
2016-03-07 15:50 [Qemu-devel] [PATCH] scsi-bus: Remove tape command from scsi_req_xfer Alex Pyrgiotis
@ 2016-03-07 16:56 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2016-03-07 16:56 UTC (permalink / raw)
To: Alex Pyrgiotis, qemu-devel
On 07/03/2016 16:50, Alex Pyrgiotis wrote:
> Remove the RECOVER_BUFFERED_DATA command from the list of commands that
> are handled by scsi_req_xfer(). Given that this command is
> tape-specific, it should be handled only by scsi_stream_req_xfer().
>
> Signed-off-by: Alex Pyrgiotis <apyrgio@arrikto.com>
>
> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
> index 6dcdbc0..a21752b 100644
> --- a/hw/scsi/scsi-bus.c
> +++ b/hw/scsi/scsi-bus.c
> @@ -989,7 +989,6 @@ static int scsi_req_xfer(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf)
> }
> /* fall through */
> case READ_10:
> - case RECOVER_BUFFERED_DATA:
> case READ_12:
> case READ_16:
> cmd->xfer *= dev->blocksize;
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-07 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-07 15:50 [Qemu-devel] [PATCH] scsi-bus: Remove tape command from scsi_req_xfer Alex Pyrgiotis
2016-03-07 16:56 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).