From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acyb8-0001sa-FD for qemu-devel@nongnu.org; Mon, 07 Mar 2016 12:05:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acyb5-0003el-5A for qemu-devel@nongnu.org; Mon, 07 Mar 2016 12:05:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acyb4-0003eX-U7 for qemu-devel@nongnu.org; Mon, 07 Mar 2016 12:05:31 -0500 References: <1457082167-12254-1-git-send-email-jitendra.kolhe@hpe.com> From: Eric Blake Message-ID: <56DDB4CA.6080904@redhat.com> Date: Mon, 7 Mar 2016 10:05:14 -0700 MIME-Version: 1.0 In-Reply-To: <1457082167-12254-1-git-send-email-jitendra.kolhe@hpe.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LrJLtLJTfGJCkr3X6NFF18oo7QLAleeW7" Subject: Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jitendra Kolhe , qemu-devel@nongnu.org, dgilbert@redhat.com Cc: simhan@hpe.com, mohan_parthasarathy@hpe.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LrJLtLJTfGJCkr3X6NFF18oo7QLAleeW7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/04/2016 02:02 AM, Jitendra Kolhe wrote: > While measuring live migration performance for qemu/kvm guest, it > was observed that the qemu doesn=E2=80=99t maintain any intelligence fo= r the > guest ram pages which are release by the guest balloon driver and > treat such pages as any other normal guest ram pages. This has direct > impact on overall migration time for the guest which has released > (ballooned out) memory to the host. >=20 > Signed-off-by: Jitendra Kolhe > --- > balloon.c | 253 +++++++++++++++++++++++++++++= +++++++- > exec.c | 3 + > hw/virtio/virtio-balloon.c | 35 ++++- > include/hw/virtio/virtio-balloon.h | 1 + > include/migration/migration.h | 1 + > include/sysemu/balloon.h | 15 ++- > migration/migration.c | 9 ++ > migration/ram.c | 23 +++- > qapi-schema.json | 5 +- > 9 files changed, 337 insertions(+), 8 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -544,11 +544,14 @@ > # been migrated, pulling the remaining pages along as needed.= NOTE: If > # the migration fails during postcopy the VM will fail. (sin= ce 2.5) > # > +# @skip-balloon: Skip scaning ram pages released by virtio-balloon dri= ver. s/scaning/scanning/ > +# (since 2.5) You've missed 2.5. In fact, this is borderline between new feature and bug fix, so you may have even missed 2.6 since soft freeze has already passed, in which case this should read 2.7. Does this need to be an option, or should it be unconditionally enabled? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LrJLtLJTfGJCkr3X6NFF18oo7QLAleeW7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW3bTKAAoJEKeha0olJ0NqJqkH+weVPS1N6bbhd4VNRxLKIJoV hb80JyVT3aF99yTV3jpXqKYbORA+Hw2NkX5tPyqp/ek8dxX7gL2kLMXXIpspRjsc Bqg7cG8TeWDmliJM8mvDxX7fduQVLr5xYI99lIYsjRJ7YugI4V5C8O7/PjiHV5np wJmpBrV+1H6f5PZsPT1t7ie6QBWid45PzerH0NKiAyvCf8cEEJiYRI14fsswxxnU 8Rw1grx/VEVTG0pKuOC9IWRKpcqqZagdr7bgYpj18LTlbCnT62jLPWy1+jN4/RWe SqUrrWgXyqPNPD3MV9ldUtDgUyEKJ4Hv39y8WLRYMfzeT5vBxJq/z1F9IDoMMQY= =Q/H8 -----END PGP SIGNATURE----- --LrJLtLJTfGJCkr3X6NFF18oo7QLAleeW7--