Re: [Qemu-devel] [Qemu-block] [PATCH v3 04/15] block: Move block dirty bitmap code to separate files

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1227 bytes --]

On 27.02.2016 10:20, Fam Zheng wrote:
> The only code change is making bdrv_dirty_bitmap_truncate public. It is
> used in block.c.
> 
> Also two long lines (bdrv_get_dirty) are wrapped.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
>  block.c                      | 360 ----------------------------------------
>  block/Makefile.objs          |   2 +-
>  block/dirty-bitmap.c         | 387 +++++++++++++++++++++++++++++++++++++++++++
>  include/block/block.h        |  35 +---
>  include/block/dirty-bitmap.h |  45 +++++
>  5 files changed, 434 insertions(+), 395 deletions(-)
>  create mode 100644 block/dirty-bitmap.c
>  create mode 100644 include/block/dirty-bitmap.h

[...]

> diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h
> new file mode 100644
> index 0000000..45c6046
> --- /dev/null
> +++ b/include/block/dirty-bitmap.h
> @@ -0,0 +1,45 @@
> +#ifndef BLOCK_DIRTY_BITMAP_H
> +#define BLOCK_DIRTY_BITMAP_H
> +
> +#include "qemu-common.h"
> +#include "qemu/hbitmap.h"
> +
> +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;

Doesn't patch 3 make this superfluous?

If so, I can remove it for you.

Max



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]