From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad0DP-0003vO-NG for qemu-devel@nongnu.org; Mon, 07 Mar 2016 13:49:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad0DO-0004Ge-VQ for qemu-devel@nongnu.org; Mon, 07 Mar 2016 13:49:11 -0500 References: <1456564857-29160-1-git-send-email-famz@redhat.com> <1456564857-29160-5-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <56DDCD1C.8000604@redhat.com> Date: Mon, 7 Mar 2016 19:49:00 +0100 MIME-Version: 1.0 In-Reply-To: <1456564857-29160-5-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AwgLR9oh6fNLj4nHa6tNSJVbw8uhjAB4C" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 04/15] block: Move block dirty bitmap code to separate files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AwgLR9oh6fNLj4nHa6tNSJVbw8uhjAB4C Content-Type: multipart/mixed; boundary="SPHqsqpLg12HGRKw6AiOre6sXfS2VNUum" From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org Message-ID: <56DDCD1C.8000604@redhat.com> Subject: Re: [Qemu-block] [PATCH v3 04/15] block: Move block dirty bitmap code to separate files References: <1456564857-29160-1-git-send-email-famz@redhat.com> <1456564857-29160-5-git-send-email-famz@redhat.com> In-Reply-To: <1456564857-29160-5-git-send-email-famz@redhat.com> --SPHqsqpLg12HGRKw6AiOre6sXfS2VNUum Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 27.02.2016 10:20, Fam Zheng wrote: > The only code change is making bdrv_dirty_bitmap_truncate public. It is= > used in block.c. >=20 > Also two long lines (bdrv_get_dirty) are wrapped. >=20 > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > block.c | 360 -----------------------------------= ----- > block/Makefile.objs | 2 +- > block/dirty-bitmap.c | 387 +++++++++++++++++++++++++++++++++++= ++++++++ > include/block/block.h | 35 +--- > include/block/dirty-bitmap.h | 45 +++++ > 5 files changed, 434 insertions(+), 395 deletions(-) > create mode 100644 block/dirty-bitmap.c > create mode 100644 include/block/dirty-bitmap.h [...] > diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.= h > new file mode 100644 > index 0000000..45c6046 > --- /dev/null > +++ b/include/block/dirty-bitmap.h > @@ -0,0 +1,45 @@ > +#ifndef BLOCK_DIRTY_BITMAP_H > +#define BLOCK_DIRTY_BITMAP_H > + > +#include "qemu-common.h" > +#include "qemu/hbitmap.h" > + > +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap; Doesn't patch 3 make this superfluous? If so, I can remove it for you. Max --SPHqsqpLg12HGRKw6AiOre6sXfS2VNUum-- --AwgLR9oh6fNLj4nHa6tNSJVbw8uhjAB4C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW3c0cAAoJEDuxQgLoOKytsYoIAIbifvNXfVOcJ0IOYry9P8SB vk4i9yPiNuDMOlW2ofsFy3bxkBxNTGc+9RsrMVGTeyOM764iAtahIoIuUeIyQXpC jy0UZwwGaSQ2/1RWOx+FWjXnJlJvXeB40YGMEQXbKRxhPXGoY9Y0G+Mc5eCHhNJw EwMsjbdNvA+kvBjNrY8b/GtvskRO2bgd1Y6tmtu+PegA5Q4aSQW8FP3qxB4K/izb DC8abAmIFGNMtKF1uhipbyommPUvnQR4irHlbweeaBjyvblFk2ePPfzrcr/h4tmt K+WsXTTRDOkzqkpcvm0le5AGEIRs1M4JGQSjblYiexkwNQldhpIcwy55FnntcT8= =p3CN -----END PGP SIGNATURE----- --AwgLR9oh6fNLj4nHa6tNSJVbw8uhjAB4C--